Skip to content

fix(regen-defs): Fix globs and clean tempfiles on INT, TERM #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronliu0130 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix(regen-defs): Fix globs and clean tempfiles on INT, TERM #381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fe652d
fix(regen-defs): Fix globs and clean tempfiles on INT, TERM
aaronliu0130 Apr 24, 2025
7abe1d2
use wildcard parameter expansion instead of eval
aaronliu0130 Nov 28, 2025
e12e484
back to eval—switch to expansion caused all kinds of breakage
aaronliu0130 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions regen-defs.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,14 @@ for folder in $folders; do
stdout_file=$(mktemp)
stderr_file=$(mktemp)

# Cleanup on interruption
cleanup() {
rm "$stdout_file" "$stderr_file"
}
trap cleanup INT TERM

# Execute the command and capture stdout and stderr
uv run "$cpplint" $cmd > "$stdout_file" 2> "$stderr_file"
eval uv run "$cpplint" $cmd > "$stdout_file" 2> "$stderr_file"
ret_code=$?

# Count the number of lines in stdout
Expand All @@ -42,7 +48,7 @@ for folder in $folders; do
} > "$file"

# Clean up temporary files
rm "$stdout_file" "$stderr_file"
cleanup
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup function is only called on successful completion of a loop iteration (line 51), but not when errors occur earlier. If uv run fails or if any operation between lines 23-48 causes the script to exit, the temporary files will not be cleaned up.

Additionally, the trap handler won't catch normal exit conditions (like the exit calls on lines 6 and 11). Consider:

  1. Adding EXIT to the trap signals: trap cleanup INT TERM EXIT
  2. Moving the trap setup earlier in the script to catch early exits

Note: If you add EXIT to the trap, you may need to prevent double-cleanup on line 51.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@aaronliu0130 aaronliu0130 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a command in between can cause termination of the entire script, and as mentioned trapping EXIT can get a bit messy.

done
cd ..
done