samples/silly-sample/src/sillycode.w (1)

1-6: Fix Copyleft sample comment to avoid extra whitespace warning and match real headers

The //#copyleft4prez2025… line both:

• Triggers an extra whitespace/comments warning (no space after //), which is why cpplint_clitest silly-simple is now seeing an extra error; and
• Uses a very non‑standard Copyleft format.

To keep this file as the Copyleft acceptance sample but avoid changing the whitespace counts, I’d suggest something like:

-//#copyleft4prez2025 super copy paste go
+// Copyleft 2025 Example Corp.  All rights reserved.

This still exercises the new Copyleft support, removes the unexpected whitespace warning on line 1 (so only line 3 is flagged), and brings cfg.def/simple.def totals back in sync with actual output.

cpplint.py (1)

2440-2442: Semantics look correct, but the any(True for ...) pattern is non‑idiomatic and redundant

Functionally this change does what the issue asks: it now treats both “copyright” and “copyleft” (case‑insensitive) as satisfying the header requirement within the first 10 real lines, so the behavior matches the PR objective.

A couple of nits you might (optionally) address:

• The generator any(True for line in lines[1:11] if ...) is harder to read than the usual any(predicate(line) for line in ...), and it still has to evaluate the predicate for each line that’s checked. This is essentially the same concern raised in the earlier review you already discussed, so treat this as a duplicate style note, not a blocker.
• You’re calling line.lower() twice per line; if you care about micro‑perf here, you could factor it once per iteration.

A clearer, still short‑circuiting version could be:

-    if not any(
-        True for line in lines[1:11] if "copyright" in line.lower() or "copyleft" in line.lower()
-    ):
+    if not any(
+        (lower := line.lower()) and ("copyright" in lower or "copyleft" in lower)
+        for line in lines[1:11]
+    ):

or, if you prefer to avoid the walrus operator for compatibility/readability:

-    if not any(
-        True for line in lines[1:11] if "copyright" in line.lower() or "copyleft" in line.lower()
-    ):
+    def _has_copyright_or_copyleft(line):
+        lower = line.lower()
+        return "copyright" in lower or "copyleft" in lower
+
+    if not any(_has_copyright_or_copyleft(line) for line in lines[1:11]):

Given the test failure mention (cpplint_clitest “silly-simple”), it would also be worth double‑checking that the updated samples/expected outputs in that test still line up with this behavior (e.g., that a “Copyleft …” line truly appears within the first 10 lines after the sentinel).

cpplint_unittest.py (1)

86-95: Minor docstring nit: use clearer notation for set difference

The phrase _ERROR_CATEGORIES~_SEEN_ERROR_CATEGORIES looks like it was meant to be a set difference (probably _ERROR_CATEGORIES - _SEEN_ERROR_CATEGORIES). Consider restoring the minus or spelling it out for clarity; it’s only a comment but currently reads a bit cryptically.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro