Skip to content

fix required skipped CI jobs #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronliu0130 wants to merge 15 commits into from
Closed

fix required skipped CI jobs #358

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3a77208
actually fix required skipped CI jobs
aaronliu0130 Apr 2, 2025
f081230
actually run stuff
aaronliu0130 Apr 2, 2025
f1b2fb4
checks out
aaronliu0130 Apr 2, 2025
a2d6fc2
bruh
aaronliu0130 Apr 2, 2025
bf44fc2
bruhh
aaronliu0130 Apr 2, 2025
3ef6e36
dewey have to append?
aaronliu0130 Apr 2, 2025
3cfdd17
fix outputs
aaronliu0130 Apr 5, 2025
29a1b49
fix condition
aaronliu0130 Apr 5, 2025
fc2a802
always() is the only one that works smh
aaronliu0130 Apr 5, 2025
e056094
dummy commits to trigger workflows again
aaronliu0130 Apr 5, 2025
19617ef
look i don't know why we can't just re-run a filtered workflow either
aaronliu0130 Apr 5, 2025
b62390d
you can't be serious
aaronliu0130 Apr 5, 2025
d5e7903
i had to do that again??
aaronliu0130 Apr 5, 2025
97048b5
pin unverified action to commit
aaronliu0130 Apr 7, 2025
360e9a7
full hash needed
aaronliu0130 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,32 @@
name: Test
on:
pull_request:
paths-ignore: "*.rst"
push:
# paths-ignore: "*.rst"
branches: [master, develop]
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
pre-commit:
check-paths:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: pipx run pre-commit run --all-files
with:
fetch-depth: 0
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
id: changes
with:
filters: |
nondoc:
- '!**/*.rst'
- run: echo 'changed=${{ steps.changes.outputs.nondoc }}' >> "$GITHUB_OUTPUT"
id: changed
outputs:
changed: ${{ steps.changed.outputs.changed }}

build-test:
needs: check-paths
if: needs.check-paths.outputs.changed == 'true'
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -41,3 +52,16 @@ jobs:
python -m pip install --editable .[dev]
- name: Test with tox
run: tox -e py

pass:
needs: build-test
if: always()
runs-on: ubuntu-latest
steps:
- name: fail if build-test ran and failed
if: ${{ needs.build-test.result == 'failure' }}
run: exit 1
- name: Curiosity
run: |
echo "$GITHUB_OUTPUT"
cat "$GITHUB_OUTPUT"