Skip to content

Drop flake8 in favor of ruff #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cclauss merged 2 commits into from
Apr 1, 2025
Merged

Drop flake8 in favor of ruff #356

cclauss merged 2 commits into from
Apr 1, 2025

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Apr 1, 2025

No description provided.

@cclauss cclauss requested a review from Copilot April 1, 2025 16:56
Copilot AI reviewed Apr 1, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the linting configuration by dropping flake8 in favor of ruff, while also updating version numbers for both ruff and the pyproject validator.

  • Updated ruff version from v0.11.0 to v0.11.2
  • Removed the flake8 repository configuration
  • Updated the validate-pyproject revision from v0.24 to v0.24.1
Files not reviewed (1)
  • .flake8: Language not supported

aaronliu0130
aaronliu0130 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the rules indeed seem to be implemented in ruff to me! Another thing you might consider doing is a monthly (ish?) pre-commit autoupdate scheduled CI job.

@cclauss cclauss merged commit b66973c into develop Apr 1, 2025
11 checks passed
@cclauss cclauss deleted the drop-flake8 branch April 1, 2025 18:59
@cclauss
Copy link
Member Author

cclauss commented Apr 1, 2025

you might consider doing is a monthly (ish?) pre-commit autoupdate scheduled CI job.

Done at https://results.pre-commit.ci/repo/github/47154941

@aaronliu0130
Copy link
Member

aaronliu0130 commented Apr 1, 2025

Correct me if I'm wrong, but isn't that just running pre-commit on the entire repository instead of bumping the versions of the pre-commit hooks?

@cclauss
Copy link
Member Author

cclauss commented Apr 1, 2025

https://pre-commit.ci says...

automatic updates: pre-commit.ci will periodically autoupdate your configuration ensuring that your hook versions are kept up to date. this autoupdate is currently scheduled weekly at approximately 16:00 UTC Monday.

@aaronliu0130
Copy link
Member

aaronliu0130 commented Apr 1, 2025

Makes sense! I'm struggling to find a run yesterday that checked for updates though, but I'll take their word for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@aaronliu0130 aaronliu0130 aaronliu0130 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @aaronliu0130