Skip to content

run_shell_command() with check=True to avoid silent failures #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cclauss wants to merge 1 commit into from
Closed

run_shell_command() with check=True to avoid silent failures #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpplint_clitest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def run_shell_command(cmd: str, args: str, cwd="."):
cwd: from which folder to run.
"""
cmd, args = cmd.split(), args.split()
proc = subprocess.run(cmd + args, cwd=cwd, capture_output=True, check=False)
proc = subprocess.run(cmd + args, cwd=cwd, capture_output=True, check=True)
out, err = proc.stdout, proc.stderr

# Make output system-agnostic, aka support Windows
Expand Down
Loading