Skip to content

include-what-you-use: Recognize c-style headers #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
norab0130 wants to merge 5 commits into from
Closed

include-what-you-use: Recognize c-style headers #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdaa950
IWYU: treat stdio.h the same way as cstdio
aaronliu0130 Feb 1, 2025
de89371
bruh moment
aaronliu0130 Feb 1, 2025
892d585
ultra bruh moment
aaronliu0130 Feb 1, 2025
e833a14
Merge branch 'develop' into include-what-you-c
aaronliu0130 Feb 1, 2025
d62eea2
Update CHANGELOG.rst
aaronliu0130 Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Changelog
Yet another overdue... hotfix. Sorry this took so long.

* The false positive for indented function parameters in namespaces was eradicated.
* build/include-what-you-use now recognizes c-style headers, such as <stdio.h> for symbols from <cstdio>. (https://github.com/cpplint/cpplint/pull/306)

2.0 (2024-10-06)
================
Expand Down
12 changes: 7 additions & 5 deletions cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6226,12 +6226,14 @@ def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
for item in sublist])

# All the lines have been processed, report the errors found.
for required_header_unstripped in sorted(required, key=required.__getitem__):
template = required[required_header_unstripped][1]
if required_header_unstripped.strip('<>"') not in include_dict:
error(filename, required[required_header_unstripped][0],
for header in sorted(required, key=required.__getitem__):
template = required[header][1]
if (header.strip('<>"') not in include_dict
and not (header.strip('<>"')[0] == 'c'
and (header.strip('<>"')[1:] + '.h') in include_dict)):
error(filename, required[header][0],
'build/include_what_you_use', 4,
'Add #include ' + required_header_unstripped + ' for ' + template)
'Add #include ' + header + ' for ' + template)


_RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<')
Expand Down
3 changes: 3 additions & 0 deletions cpplint_unittest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,9 @@ def testIncludeWhatYouUse(self):
self.TestIncludeWhatYouUse(
'printf("hello world");',
'Add #include <cstdio> for printf [build/include_what_you_use] [4]')
self.TestIncludeWhatYouUse(
"""#include <stdio.h>
printf("hello world");""", '') # Avoid false positives w/ c-style include
self.TestIncludeWhatYouUse(
'void a(const string &foobar);',
'Add #include <string> for string [build/include_what_you_use] [4]')
Expand Down
3 changes: 1 addition & 2 deletions samples/vlc-sample/simple.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ src/*
Done processing src/libvlc.c
Done processing src/libvlc.h
Done processing src/missing.c
Total errors found: 602
Total errors found: 601

src/libvlc.c:41: Found C system header after other header. Should be: libvlc.h, c system, c++ system, other. [build/include_order] [4]
src/libvlc.c:47: Found C system header after other header. Should be: libvlc.h, c system, c++ system, other. [build/include_order] [4]
Expand Down Expand Up @@ -367,7 +367,6 @@ src/libvlc.c:627: Missing space before ( in if( [whitespace/parens] [5]
src/libvlc.c:629: Extra space after ( in function call [whitespace/parens] [4]
src/libvlc.c:629: Extra space before ) [whitespace/parens] [2]
src/libvlc.c:640: { should almost always be at the end of the previous line [whitespace/braces] [4]
src/libvlc.c:223: Add #include <cstdio> for fclose [build/include_what_you_use] [4]
src/libvlc.h:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_VLC_SAMPLE_SRC_LIBVLC_H_ [build/header_guard] [5]
src/libvlc.h:34: Extra space before ( in function call [whitespace/parens] [4]
src/libvlc.h:35: Extra space before ( in function call [whitespace/parens] [4]
Expand Down
Loading