Skip to content

Fix false positive on concept declaration #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronliu0130 merged 3 commits into from
Sep 17, 2024
Merged

Fix false positive on concept declaration #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aadb43
Add concept tests.
armandas Sep 10, 2024
dd194e8
Add exception rule for concepts.
armandas Sep 10, 2024
d78ba71
Add to changelog
aaronliu0130 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ A bunch of long-overdue modernizations of the codebase!
* Indented functions inside namespaces will now be correctly erred on, courtesy of @Yujinmon (https://github.com/cpplint/cpplint/pull/235)
* The check for C-style casts now looks for the standard fixed-width integer typenames instead of non-standard ones (e.g. int32_t instead of int32) thanks to @nate-thirdwave (https://github.com/cpplint/cpplint/pull/282)
* `[[(un)likely]]` no longer clouds readability/braces's super spy−scanning of braces, courtesy of @aaronliu0130 (https://github.com/cpplint/cpplint/pull/265)
* `readability/braces` will realize that C++20 concepts require a semicolon, courtesy of @armandas (https://github.com/cpplint/cpplint/pull/288)
* C++20 headers will no longer be flagged as C headers thanks to @miker2 (https://github.com/cpplint/cpplint/pull/216)
* Same goes for C++23 and C23 headers, thanks to @aaronliu0130 (https://github.com/cpplint/cpplint/pull/239)
* "complex.h" will be treated as the C99 header instead of the legacy C++ header by @tkruse (https://github.com/cpplint/cpplint/pull/219)
Expand Down
2 changes: 2 additions & 0 deletions cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4539,6 +4539,7 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
# - Lambdas
# - alignas specifier with anonymous structs
# - decltype
# - concepts (requires expression)
closing_brace_pos = match.group(1).rfind(')')
opening_parenthesis = ReverseCloseExpression(
clean_lines, linenum, closing_brace_pos)
Expand All @@ -4554,6 +4555,7 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
(func and not re.search(r'\boperator\s*\[\s*\]', func.group(1))) or
re.search(r'\b(?:struct|union)\s+alignas\s*$', line_prefix) or
re.search(r'\bdecltype$', line_prefix) or
re.search(r'\brequires.*$', line_prefix) or
re.search(r'\s+=\s*$', line_prefix)):
match = None
if (match and
Expand Down
15 changes: 15 additions & 0 deletions cpplint_unittest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2807,6 +2807,21 @@ def testSemiColonAfterBraces(self):

self.TestLint('file_tocs_[i] = (FileToc) {a, b, c};', '')
self.TestMultiLineLint('class X : public Y,\npublic Z {};', '')
self.TestMultiLineLint('template<typename T>\n'
'concept Addable = requires(T x) { x + x; };',
'')
self.TestMultiLineLint('template <typename T>\n'
'concept C = requires(T a, T b) {\n'
' requires a == b;\n'
'};',
'')
self.TestMultiLineLint('template <typename T, typename U>\n'
'concept C = (std::integral<T> || std::floating_point<T>) &&\n'
' (std::integral<U> || std::floating_point<U>) &&\n'
' requires(T t, U u) {\n'
' std::min(static_cast<float>(t), static_cast<float>(u));\n'
'};',
'')

def testSpacingBeforeBrackets(self):
self.TestLint('int numbers [] = { 1, 2, 3 };',
Expand Down