Update silly-sample + gitignore vscode (#253) #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernized to include more violations that we could potentially detect Combined with cfg-sample Also gitignore vscode stuff now
meanwhile, i've identified an absolutely stupid bug in searching for the config file.
The Google C++ style guide mandates all C++ and C system headers to be included with <>. We currently don't even realize that a header surrounded with "" is a system header, and both features should be added some time in the future.
…o aaronliu0130-develop
norab0130
changed the title
aaronliu0130
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernized to include more violations that we could potentially detect
Combined with cfg-sample
Also gitignore vscode stuff now