Skip to content

Conversation

@ember91
Copy link
Contributor

@ember91 ember91 commented Jul 7, 2024

Apparently it was renamed, breaking some documentation in the process.

Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this a while ago and would actually prefer the opposite: renaming changelog.rst to CHANGELOG.rst so it's consistent with other documentation.

@ember91
Copy link
Contributor Author

ember91 commented Jul 8, 2024

Yes. Do want you want here. To me it does not matter.

@aaronliu0130
Copy link
Member

Thanks, but it'd be easier for all of us here if you committed the changes to your own branch, since we have mandatory review here yet all the other maintainers are inactive while I do not have the power to add other maintainers.

For consistency with other .rst files in the root.

This also fixes some documentation that previously referred to the
uppercased name.
@ember91 ember91 changed the title Change references to CHANGELOG.rst to changelog.rst Rename changelog.rst to CHANGELOG.rst Jul 8, 2024
@ember91
Copy link
Contributor Author

ember91 commented Jul 8, 2024

Thanks, but it'd be easier for all of us here if you committed the changes to your own branch, since we have mandatory review here yet all the other maintainers are inactive while I do not have the power to add other maintainers.

Can you have a look now?

Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay, I had some academci commitments. LGTM!

@aaronliu0130 aaronliu0130 merged commit e133524 into cpplint:develop Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants