Add support for [[likely]] and misc brace bugfixes #265
Conversation
A chromium sample has been updated to a version that uses C++17 stuff READMEs of samples have been clarified regarding licensing Two licenses have also been updated Skip CI because I amended a typo in the commit message
1. Fixes cpplint#212 2. else statements that have braces on both sides but have the second-to-last } on a separate line will no longer claim we need braces on both sides 3. Fix single-line if statements being yelled at to split their lines, something contradictory to the style guide 4. Fixes relevant tests, including adding the new "TestLintContains" and "TestLintNotContains" methods. (ik the latter may have a grammar error but who cares, this is consistent with the former's name) 5. Add a todo for "This exception does not apply to multi-keyword statements like if ... else or do ... while."
|
@jayvdb My implementation utilizes a feature from 3.8; 3.7 is EOL. Should we replace the 3.7 tests with 3.8 before releasing 1.7? Or should we do an implementation of the essential feature of handling [[(un)likely]] to put in 1.7, and release 1.7.1 with this? Or should we just release 1.7 as is and release 1.8 with this and maybe other stuff? |
|
Hey @jayvdb, any thoughts? FYI The feature used is |
|
Would love to see this merged, as currently it breaks pipeline with false positives. |
|
It's not a false positive per se; it fails because it uses a language feature not present in 3.7, an EOL version. Anyways I'll merge this soon. |
Needed to use the `:=` operator
...to our varname style guide. Was previously 534a142 but I forgot to pull from my own branch. Darn... Early-onset dementia? *knocks on wood*
|
Closing to merge in #277 |
2 participants
This PR contains changes from #255 due to a mistake. That won't affect what'll be merged.
[[likely]]/[[unlikely]]attribute support #212