Skip to content

Update chromium sample and clarify sample READMEs #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronliu0130 merged 3 commits into from
Feb 29, 2024
Merged

Update chromium sample and clarify sample READMEs #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
935c4d7
Update chromium sample and clarify READMEs [skip ci]
aaronliu0130 Feb 24, 2024
01d6baa
Update .def
aaronliu0130 Feb 24, 2024
d8292c4
clarify licenses as BSD, including ours
aaronliu0130 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions samples/boost-sample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
# VLC sample

code taken for regression testing from https://github.com/boostorg
Code under include/ and src/ taken from https://github.com/boostorg, licensed under the Boost license.
27 changes: 27 additions & 0 deletions samples/chromium-sample/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2015 The Chromium Authors
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google LLC nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
4 changes: 1 addition & 3 deletions samples/chromium-sample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
# VLC sample

code taken for regression testing from https://github.com/chromium/chromium
Code under src/ taken from https://github.com/chromium/chromium, licensed under the BSD 3-clause.
12 changes: 4 additions & 8 deletions samples/chromium-sample/simple.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@ Done processing src/chrome_content_renderer_client.cc
Done processing src/chrome_content_renderer_client.h
Done processing src/io_thread.cc
Done processing src/io_thread.h
Total errors found: 21
Total errors found: 17

src/chrome_content_renderer_client.cc:113: Include the directory when naming header files [build/include_subdir] [4]
src/chrome_content_renderer_client.cc:1156: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/chrome_content_renderer_client.cc:1161: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
src/chrome_content_renderer_client.cc:1203: Add #include <set> for set<> [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:1245: Add #include <vector> for vector<> [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:1359: Add #include <map> for map<> [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:1366: Add #include <string> for string [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:308: Add #include <vector> for vector<> [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:1540: Add #include <set> for set<> [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:1841: Add #include <string> for string [build/include_what_you_use] [4]
src/chrome_content_renderer_client.cc:5: samples/chromium-sample/src/chrome_content_renderer_client.cc should include its header file samples/chromium-sample/src/chrome_content_renderer_client.h [build/include] [5]
src/chrome_content_renderer_client.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_ [build/header_guard] [5]
src/chrome_content_renderer_client.h:225: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_" [build/header_guard] [5]
Expand Down
2,227 changes: 1,329 additions & 898 deletions samples/chromium-sample/src/chrome_content_renderer_client.cc
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions samples/codelite-sample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
Canary sample taken from codelite https://github.com/eranif/codelite
License applies as per LICENSE file in this folder
Code under src/ taken from https://github.com/eranif/codelite, licensed under the GPL2.
4 changes: 1 addition & 3 deletions samples/protobuf-sample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
# VLC sample

code taken for regression testing from https://github.com/protocolbuffers/protobuf
Code under src/ taken from https://github.com/protocolbuffers/protobuf, licensed under the BSD 3-clause.
3 changes: 1 addition & 2 deletions samples/v8-sample/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright 2006-2011, the V8 project authors. All rights reserved.
Copyright 2014, the V8 project authors. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
Expand All @@ -24,4 +24,3 @@ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

4 changes: 1 addition & 3 deletions samples/v8-sample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
# V8 sample

code taken for regression testing from https://github.com/v8/v8
Code under src/ taken from https://github.com/v8/v8, licensed under the BSD 3-clause.
4 changes: 1 addition & 3 deletions samples/vlc-sample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
# VLC sample

code taken for regression testing from https://github.com/videolan/vlc
Code under src/ taken from https://github.com/videolan/vlc, licensed under the GPL2.
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ def read_without_comments(filename):
classifiers=['Development Status :: 5 - Production/Stable',
'Environment :: Console',
'Intended Audience :: End Users/Desktop',
'License :: Freely Distributable'
'License :: Freely Distributable',
'License :: OSI Approved :: BSD License',
'Natural Language :: English',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.7',
Expand Down