Skip to content

avoid false positives on transform issue27 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geoffviola wants to merge 1 commit into from
Closed

avoid false positives on transform issue27 #217

geoffviola wants to merge 1 commit into from

Conversation

@geoffviola
Copy link
Contributor

@geoffviola geoffviola commented Dec 31, 2022

This PR addresses #27

I noticed some false positives when using transform in other namespaces. There may be some new false negatives when using namespace std is used and std:: is omitted, but it seems worth it.

@tkruse tkruse force-pushed the develop branch 5 times, most recently from b683f2b to 2cb090b Compare January 29, 2023 12:33
@tkruse
Copy link
Contributor

tkruse commented Jan 29, 2023

Since cpplint has been used in the past to detect missing includes when using using namespace std, I am not sure that it's reasonable to make a change to cpplint to make those false negatives. I would prefer a solution reducing false positives without creating false negatives.

@geoffviola geoffviola closed this Jan 29, 2023
@grantwwu
Copy link

grantwwu commented Apr 6, 2023

Could the behavior be controlled through an option?

@geoffviola geoffviola mentioned this pull request Mar 20, 2024
Merged
aaronliu0130 pushed a commit that referenced this pull request Mar 20, 2024
@geoffviola
Avoid IWYU False Positives on external libraries (#266)
3791cc4 
Follow-up to #217, another try to fix #27. This stops IWYU on erring on tokens with namespace prefixes that aren't std.
This change should preserve backward compatibility while preventing false positives for common names in other namespaces.
@geoffviola geoffviola mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geoffviola @tkruse @grantwwu