Repository navigation
False positive with unnamed function parameter #131
Description
With the following example file:
void foo(int)
{
return;
}I get:
# cpplint test.cpp
...
test.cpp:1: Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]
...
# cpplint --version
Cpplint fork (https://github.com/cpplint/cpplint)
cpplint 1.4.5
Python 3.8.0 (default, Nov 23 2019, 05:49:00)
[GCC 8.3.0]
There isn't a cast in this file; it's picking up the parameter type in the function definition.
I removed the parameter name to avoid "unused variable" warnings (https://stackoverflow.com/a/15763959/2422874).
Activity
tkruse commentedon Jun 2, 2020
It seems that this is avoided when the curly braces are at the end of the line.
cpplint.py already tries to avoid this false positive, but the code to do so in
CheckCasts(is very contrived, and I am not brave enough to try to fix this.Apply CPPLint to C++ Unit Tests
Apply CPPLint to C++ Unit Tests
Apply CPPLint to C++ Unit Tests (#8827)
Squashed commit of the following:
Apply CPPLint to C++ Unit Tests (apache#8827)
Apply CPPLint to C++ Unit Tests (apache#8827)
Apply CPPLint to C++ Unit Tests (apache#8827)
ci/linter exclude file with false positive
ci/linter exclude file with false positive (#165)
vkucera commentedon Jul 8, 2024
Any prospects on fixing this bug?
Workaround cpplint bug cpplint/cpplint#131
Apply CPPLint to C++ Unit Tests (#8827)