Skip to content

Commit 756c728

Browse files
author
Povilas Kanapickas
committed
Transform/DDG: update comments
1 parent b02eb90 commit 756c728

File tree

1 file changed

+23
-18
lines changed

1 file changed

+23
-18
lines changed

index2ddg.py

Lines changed: 23 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -53,19 +53,19 @@
5353
items = {}
5454

5555
# Entry types
56-
# class or struct
56+
# a class or struct
5757
ITEM_TYPE_CLASS = 1
5858

59-
# member function or free function
59+
# a member function or free function
6060
ITEM_TYPE_FUNCTION = 2
6161

62-
# member function that is described in the same page as the class
62+
# a member function that is described in the same page as the class
6363
ITEM_TYPE_FUNCTION_INLINEMEM = 3
6464

65-
# enum
65+
# an enum
6666
ITEM_TYPE_ENUM = 4
6767

68-
# a value of enum
68+
# a value of an enum
6969
ITEM_TYPE_ENUM_CONST = 5
7070

7171
def get_item_type(el):
@@ -189,7 +189,7 @@ def build_abstract(decls, desc):
189189
else:
190190
if code_num_lines > line_limit - 1:
191191
# -1 because we need to take into account
192-
# <more overloads omitted> message
192+
# < omitted declarations > message
193193
limited = True
194194
break
195195

@@ -200,7 +200,6 @@ def build_abstract(decls, desc):
200200
if limited:
201201
all_code += '<pre><code> &lt; omitted declarations &gt; </code></pre>'
202202

203-
204203
# count the number of lines used
205204
num_lines += all_code.count('\n')
206205
if len(desc) > 110:
@@ -265,22 +264,28 @@ def build_abstract(decls, desc):
265264
abstract = build_abstract(decls, desc)
266265

267266
elif item_type == ITEM_TYPE_FUNCTION_INLINEMEM:
268-
raise DdgException("INLINEMEM")
269-
''' (see versioned declarations, picking up the text)
270-
declaration is selected from the member table
271-
the member table is found according to the identifier (last part after :: is enough, hopefully
267+
raise DdgException("INLINEMEM") # not implemented
268+
''' Implementation notes:
269+
* the declarations are possibly versioned
270+
* declaration is selected from the member table
271+
* the member table is found according to the identifier
272+
(last part after :: is enough, hopefully)
272273
'''
273274

274275
elif item_type == ITEM_TYPE_ENUM:
275-
raise DdgException("ENUM")
276-
''' (see versioned declarations, picking up the text) '''
276+
raise DdgException("ENUM") # not implemented
277+
''' Implementation notes:
278+
* the declarations are possibly versioned
279+
'''
277280

278281
elif item_type == ITEM_TYPE_ENUM_CONST:
279-
raise DdgException("ENUM_CONST")
280-
''' search for the const -> definition table before the first heading
281-
search for const in code, pick the definition either:
282-
within enum declaration, result in ... const ...
283-
external enum, the declaration is since the last punctuation till the ';', ',', etc
282+
raise DdgException("ENUM_CONST") # not implemented
283+
''' Implementation notes:
284+
* the abstract will come from the const -> definition table,
285+
which is always put before the first heading.
286+
* the declaration will come from the dcl template. We need
287+
to split the content at ';' and ',', then search for the
288+
name of the enum. If we find duplicates, signal an error.
284289
'''
285290

286291
# title

0 commit comments

Comments
 (0)