Fix 275558 Missing call to va_end

Colin Robertson · Colin Robertson · commit ed1273ba8e42 · 2017-01-12T13:01:46.000-08:00
diff --git a/docs/c-runtime-library/reference/va-arg-va-copy-va-end-va-start.md b/docs/c-runtime-library/reference/va-arg-va-copy-va-end-va-start.md
@@ -72,11 +72,11 @@ Accesses variable-argument lists.
 ## Syntax  
   
 ```  
-  
-      type va_arg(  
+type va_arg(  
    va_list arg_ptr,  
    type   
-);void va_copy(  
+);
+void va_copy(  
    va_list dest,  
    va_list src  
 ); // (ISO C99 and later)  
@@ -89,7 +89,7 @@ void va_start(
 ); // (ANSI C89 and later)  
 void va_start(  
    arg_ptr   
-);  // (Pre-ANSI C89 standardization version)  
+);  // (deprecated Pre-ANSI C89 standardization version)  
 ```  
   
 #### Parameters  
@@ -150,6 +150,8 @@ void testit (int i, ...)
         char *s = va_arg(argptr, char*);  
         printf("%s\n", s);  
     }  
+
+    va_end(argptr);  
 }  
   
 int main()  
diff --git a/docs/c-runtime-library/reference/vcprintf-p-vcprintf-p-l-vcwprintf-p-vcwprintf-p-l.md b/docs/c-runtime-library/reference/vcprintf-p-vcprintf-p-l-vcwprintf-p-vcwprintf-p-l.md
@@ -148,18 +148,19 @@ int _vcwprintf_p_l(
 ## Example  
   
 ```  
-  
-      // crt_vcprintf_p.c  
+// crt_vcprintf_p.c  
 // compile with: /c  
 #include <conio.h>  
 #include <stdarg.h>  
   
 // An error formatting function that's used to print to the console.  
 int eprintf(const char* format, ...)  
 {  
-  va_list args;  
-  va_start(args, format);  
-  return _vcprintf_p(format, args);  
+   va_list args;  
+   va_start(args, format);  
+   int result = _vcprintf_p(format, args);  
+   va_end(args);  
+   return result;
 }  
   
 int main()  
diff --git a/docs/c-runtime-library/reference/vcprintf-s-vcprintf-s-l-vcwprintf-s-vcwprintf-s-l.md b/docs/c-runtime-library/reference/vcprintf-s-vcprintf-s-l-vcwprintf-s-vcwprintf-s-l.md
@@ -156,7 +156,9 @@ int eprintf_s(const char* format, ...)
 {  
   va_list args;  
   va_start(args, format);  
-  return _vcprintf_s(format, args);  
+  int result = _vcprintf_s(format, args);  
+  va_end(args);  
+  return result;
 }  
   
 int main()  
diff --git a/docs/c-runtime-library/reference/vcprintf-vcprintf-l-vcwprintf-vcwprintf-l.md b/docs/c-runtime-library/reference/vcprintf-vcprintf-l-vcwprintf-vcwprintf-l.md
@@ -155,7 +155,9 @@ int eprintf(const char* format, ...)
 {  
   va_list args;  
   va_start(args, format);  
-  return _vcprintf(format, args);  
+  int result = _vcprintf(format, args);  
+  va_end(args);  
+  return result;  
 }  
   
 int main()  
diff --git a/docs/c-runtime-library/reference/vsnprintf-s-vsnprintf-s-vsnprintf-s-l-vsnwprintf-s-vsnwprintf-s-l.md b/docs/c-runtime-library/reference/vsnprintf-s-vsnprintf-s-vsnprintf-s-l-vsnwprintf-s-vsnwprintf-s-l.md
@@ -215,7 +215,8 @@ void FormatOutput(LPCSTR formatstring, ...)
    va_list args;  
    va_start(args, formatstring);  
    nSize = vsnprintf_s( buff, _countof(buff), _TRUNCATE, formatstring, args);  
-   printf("nSize: %d, buff: %s\n", nSize, buff);  
+   printf("nSize: %d, buff: %s\n", nSize, buff); 
+   va_end(args); 
 }  
   
 int main() {  
diff --git a/docs/c-runtime-library/reference/vsnprintf-vsnprintf-vsnprintf-l-vsnwprintf-vsnwprintf-l.md b/docs/c-runtime-library/reference/vsnprintf-vsnprintf-vsnprintf-l-vsnwprintf-vsnwprintf-l.md
@@ -241,6 +241,7 @@ void FormatOutput(LPCWSTR formatstring, ...)
     // Note: _vsnwprintf is deprecated; consider vsnwprintf_s instead  
     nSize = _vsnwprintf(buff, BUFFCOUNT - 1, formatstring, args); // C4996  
     wprintf(L"nSize: %d, buff: %ls\n", nSize, buff);  
+    va_end(args);
 }  
   
 int main() {  
@@ -277,7 +278,8 @@ void FormatOutput(char* formatstring, ...)
     va_list args;  
     va_start(args, formatstring);  
     nSize = vsnprintf(buff, sizeof(buff), formatstring, args);  
-    printf("nSize: %d, buff: %s\n", nSize, buff);  
+    printf("nSize: %d, buff: %s\n", nSize, buff);
+    va_end(args);  
 }  
   
 int main() {  
diff --git a/docs/c-runtime-library/reference/vsprintf-p-vsprintf-p-l-vswprintf-p-vswprintf-p-l.md b/docs/c-runtime-library/reference/vsprintf-p-vsprintf-p-l-vswprintf-p-vswprintf-p-l.md
@@ -183,6 +183,7 @@ void example( char * format, ... )
         puts( buffer );  
         free( buffer );  
     }  
+    va_end( args );
 }  
   
 int main( void )  
diff --git a/docs/c-runtime-library/reference/vsprintf-s-vsprintf-s-l-vswprintf-s-vswprintf-s-l.md b/docs/c-runtime-library/reference/vsprintf-s-vsprintf-s-l-vswprintf-s-vswprintf-s-l.md
@@ -183,7 +183,8 @@ void test( char * format, ... )
    buffer = malloc( len * sizeof(char) );  
    vsprintf_s( buffer, len, format, args );  
    puts( buffer );  
-   free( buffer );  
+   free( buffer );
+   va_end( args );  
 }  
   
 int main( void )  
diff --git a/docs/c-runtime-library/reference/vsprintf-vsprintf-l-vswprintf-vswprintf-l-vswprintf-l.md b/docs/c-runtime-library/reference/vsprintf-vsprintf-l-vswprintf-vswprintf-l-vswprintf-l.md
@@ -219,7 +219,8 @@ void test( char * format, ... )
     // Note: vsprintf is deprecated; consider using vsprintf_s instead  
     puts( buffer );  
   
-    free( buffer );  
+    free( buffer ); 
+    va_end( args ); 
 }  
   
 int main( void )  

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,9 @@ int eprintf_s(const char* format, ...)`
`156`	`156`	`{`
`157`	`157`	`va_list args;`
`158`	`158`	`va_start(args, format);`
`159`		`- return _vcprintf_s(format, args);`
	`159`	`+ int result = _vcprintf_s(format, args);`
	`160`	`+ va_end(args);`
	`161`	`+ return result;`
`160`	`162`	`}`
`161`	`163`
`162`	`164`	`int main()`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,9 @@ int eprintf(const char* format, ...)`
`155`	`155`	`{`
`156`	`156`	`va_list args;`
`157`	`157`	`va_start(args, format);`
`158`		`- return _vcprintf(format, args);`
	`158`	`+ int result = _vcprintf(format, args);`
	`159`	`+ va_end(args);`
	`160`	`+ return result;`
`159`	`161`	`}`
`160`	`162`
`161`	`163`	`int main()`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,8 @@ void FormatOutput(LPCSTR formatstring, ...)`
`215`	`215`	`va_list args;`
`216`	`216`	`va_start(args, formatstring);`
`217`	`217`	`nSize = vsnprintf_s( buff, _countof(buff), _TRUNCATE, formatstring, args);`
`218`		`- printf("nSize: %d, buff: %s\n", nSize, buff);`
	`218`	`+ printf("nSize: %d, buff: %s\n", nSize, buff);`
	`219`	`+ va_end(args);`
`219`	`220`	`}`
`220`	`221`
`221`	`222`	`int main() {`
Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ void example( char * format, ... )`
`183`	`183`	`puts( buffer );`
`184`	`184`	`free( buffer );`
`185`	`185`	`}`
	`186`	`+ va_end( args );`
`186`	`187`	`}`
`187`	`188`
`188`	`189`	`int main( void )`
Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,8 @@ void test( char * format, ... )`
`183`	`183`	`buffer = malloc( len * sizeof(char) );`
`184`	`184`	`vsprintf_s( buffer, len, format, args );`
`185`	`185`	`puts( buffer );`
`186`		`- free( buffer );`
	`186`	`+ free( buffer );`
	`187`	`+ va_end( args );`
`187`	`188`	`}`
`188`	`189`
`189`	`190`	`int main( void )`
Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,8 @@ void test( char * format, ... )`
`219`	`219`	`// Note: vsprintf is deprecated; consider using vsprintf_s instead`
`220`	`220`	`puts( buffer );`
`221`	`221`
`222`		`- free( buffer );`
	`222`	`+ free( buffer );`
	`223`	`+ va_end( args );`
`223`	`224`	`}`
`224`	`225`
`225`	`226`	`int main( void )`