Skip to content

Commit 417bb54

Browse files
committed
ok insert works but update doesnt this is a pain
1 parent 78e2211 commit 417bb54

3 files changed

Lines changed: 55 additions & 12 deletions

File tree

‎Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
test:
2-
pytest --tb=short
2+
pytest --tb=short -vv
33

44
watch-tests:
5-
ls *.py | entr pytest --tb=short
5+
ls *.py | entr pytest --tb=short -vv

‎orm.py‎

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
from sqlalchemy import Table, MetaData, Column, Integer, String, ForeignKey
2-
from sqlalchemy.orm import mapper, relationship, column_property
3-
from sqlalchemy.orm.collections import attribute_mapped_collection, mapped_collection, collection
2+
from sqlalchemy import event
3+
from sqlalchemy.orm import mapper, relationship
44

55
from domain_model import Order
66

7-
metadata = MetaData()
87

8+
metadata = MetaData()
99

1010
order = Table(
1111
'order', metadata,
1212
Column('id', Integer, primary_key=True, autoincrement=True),
13-
# relationship('order_lines', secondary='order_lines')
1413
)
1514

1615
order_lines = Table(
@@ -20,21 +19,34 @@
2019
Column('qty', Integer),
2120
)
2221

22+
from dataclasses import dataclass
2323

24+
@dataclass
2425
class _DummyOrderLine:
25-
pass
26+
'''dummy type to map order lines, will convert them to and from dicts in events below'''
27+
order_id: int
28+
sku: str
29+
qty: int
2630

2731

2832
mapper(_DummyOrderLine, order_lines)
2933
mapper(Order, order, properties={
30-
'__lines': relationship(_DummyOrderLine)
34+
'__lines': relationship(_DummyOrderLine),
3135
})
3236

3337

34-
from sqlalchemy import event
3538

36-
# standard decorator style
3739
@event.listens_for(Order, 'load')
3840
def custom_load(target, context):
39-
breakpoint()
4041
target._lines = {l.sku: l.qty for l in target.__lines}
42+
target.__lines.clear()
43+
44+
@event.listens_for(Order, 'after_insert')
45+
def custom_insert(mapper, connection, target):
46+
for sku, qty in target._lines.items():
47+
target.__lines.append(_DummyOrderLine(order_id=target.id, sku=sku, qty=qty))
48+
49+
@event.listens_for(_DummyOrderLine, 'before_insert')
50+
def custom_update(mapper, connection, target):
51+
breakpoint()
52+
print(target)

‎test_orm.py‎

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def test_order_mapper_no_lines(session):
3232
session.add(order)
3333
assert session.query(Order).first() == order
3434

35-
def test_order_mapper_with_lines(session):
35+
def test_order_mapper_can_load_lines(session):
3636
session.execute('INSERT INTO "order" VALUES (1)')
3737
session.execute('INSERT INTO "order" VALUES (2)')
3838
session.execute('INSERT INTO "order_lines" VALUES (1, "sku1", 12)')
@@ -41,3 +41,34 @@ def test_order_mapper_with_lines(session):
4141
expected_order = Order({'sku1': 12, 'sku2': 13})
4242
retrieved_order = session.query(Order).first()
4343
assert retrieved_order.lines == expected_order.lines
44+
45+
46+
def test_order_mapper_can_save_lines(session):
47+
new_order = Order({'sku1': 12, 'sku2': 13})
48+
session.add(new_order)
49+
session.commit()
50+
51+
rows = list(session.execute('SELECT * FROM "order_lines"'))
52+
assert rows == [
53+
(1, 'sku1', 12),
54+
(1, 'sku2', 13),
55+
]
56+
57+
def test_order_mapper_can_edit_lines(session):
58+
session.execute('INSERT INTO "order" VALUES (1)')
59+
session.execute('INSERT INTO "order" VALUES (2)')
60+
session.execute('INSERT INTO "order_lines" VALUES (1, "sku1", 12)')
61+
session.execute('INSERT INTO "order_lines" VALUES (1, "sku2", 13)')
62+
session.execute('INSERT INTO "order_lines" VALUES (2, "sku3", 14)')
63+
64+
order = session.query(Order).first()
65+
order._lines['sku4'] = 99
66+
session.add(order)
67+
session.commit()
68+
69+
rows = list(session.execute('SELECT * FROM "order_lines" WHERE order_id=1'))
70+
assert rows == [
71+
(1, 'sku1', 12),
72+
(1, 'sku2', 13),
73+
(1, 'sku4', 13),
74+
]

0 commit comments

Comments
 (0)