Skip to content

Commit 1368b29

Browse files
committed
make even more complicated, two handlers
1 parent 0c2e17b commit 1368b29

2 files changed

Lines changed: 48 additions & 20 deletions

File tree

‎domain.py‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
from dataclasses import dataclass
2+
from datetime import date
3+
from typing import List, Optional
4+
5+
@dataclass
6+
class OrderLine:
7+
sku: str
8+
qty: int
9+
10+
11+
@dataclass
12+
class Shipment:
13+
reference: str
14+
lines: List[OrderLine]
15+
eta: Optional[date]
16+
incoterm: str
17+
18+
def save(self):
19+
...

‎sync_shipments.py‎

Lines changed: 29 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,49 @@
11
import logging
2+
import uuid
23
from dataclasses import dataclass
34
from datetime import date
4-
from typing import List, Optional
5+
from typing import Dict, List, Optional
56
import requests
67
import requests.exceptions
78

9+
from domain import Shipment, OrderLine
810
from notifications import notify_delay, notify_new_large_shipment
911

1012
API_URL = 'https://example.org'
1113

12-
@dataclass
13-
class OrderLine:
14-
sku: str
15-
qty: int
1614

15+
def create_shipment(quantities: Dict[str, int], incoterm):
16+
reference = uuid.uuid4().hex[:10]
17+
order_lines = [OrderLine(sku=sku, qty=qty) for sku, qty in quantities.items()]
18+
shipment = Shipment(reference=reference, lines=order_lines, eta=None, incoterm=incoterm)
19+
shipment.save()
20+
sync_to_api(shipment)
1721

18-
@dataclass
19-
class Shipment:
20-
reference: str
21-
lines: List[OrderLine]
22-
eta: Optional[date]
23-
incoterm: str
2422

23+
def get_updated_eta(shipment):
24+
external_shipment_id = get_shipment_id(shipment.reference)
25+
if external_shipment_id is None:
26+
logging.warning(
27+
'tried to get updated eta for shipment %s not yet sent to partners',
28+
shipment.reference
29+
)
30+
return
2531

26-
def set_eta(shipment, eta):
32+
[journey] = requests.get(f"{API_URL}/shipments/{external_shipment_id}/journeys").json()['items']
33+
latest_eta = journey['eta']
34+
if latest_eta == shipment.eta:
35+
return
2736
logging.info(
2837
'setting new shipment eta for %s: %s (was %s)',
29-
shipment.reference, eta, shipment.eta
38+
shipment.reference, latest_eta, shipment.eta
3039
)
31-
if shipment.eta is not None and eta > shipment.eta:
32-
notify_delay(shipment_ref=shipment.reference, delay=eta - shipment.eta)
40+
if shipment.eta is not None and latest_eta > shipment.eta:
41+
notify_delay(shipment_ref=shipment.reference, delay=latest_eta - shipment.eta)
3342
if shipment.eta is None and shipment.incoterm == 'FOB' and len(shipment.lines) > 10:
34-
notify_new_large_shipment(shipment_ref=shipment.reference, eta=eta)
43+
notify_new_large_shipment(shipment_ref=shipment.reference, eta=latest_eta)
3544

36-
shipment.eta = eta
37-
sync_to_api(shipment)
45+
shipment.eta = latest_eta
46+
shipment.save()
3847

3948

4049

@@ -43,7 +52,7 @@ def sync_to_api(shipment):
4352
if external_shipment_id is None:
4453
requests.post(f'{API_URL}/shipments/', json={
4554
'client_reference': shipment.reference,
46-
'arrival_date': shipment.eta.isoformat()[:10],
55+
'arrival_date': shipment.eta,
4756
'products': [
4857
{'sku': ol.sku, 'quantity': ol.quantity}
4958
for ol in shipment.lines
@@ -53,7 +62,7 @@ def sync_to_api(shipment):
5362
else:
5463
requests.put(f'{API_URL}/shipments/{external_shipment_id}', json={
5564
'client_reference': shipment.reference,
56-
'arrival_date': shipment.eta.isoformat()[:10],
65+
'arrival_date': shipment.eta,
5766
'products': [
5867
{'sku': ol.sku, 'quantity': ol.quantity}
5968
for ol in shipment.lines

0 commit comments

Comments
 (0)