Skip to content

fixed #13066 - Makefile: need to use override when appending to variable specified on the command-line - #6765

Merged
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:filesdir-x
Sep 18, 2024
Merged

fixed #13066 - Makefile: need to use override when appending to variable specified on the command-line#6765
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:filesdir-x

Conversation

@firewave

@firewave firewave commented Sep 2, 2024

Copy link
Copy Markdown
Collaborator

@firewave

firewave commented Sep 2, 2024

Copy link
Copy Markdown
Collaborator Author

#4968 (comment) mentions that you should not use override but it is in line with what we are currently doing.

There are other places where this should be added but I refrained from that as it might introduce issues instead of fixing them.

This should be properly addressed after #4968 has been merged.

I will also prepare a backport after this was merged.

@firewave

Copy link
Copy Markdown
Collaborator Author

No feedback in over two weeks - merging.

@firewave
firewave merged commit f88d2c8 into cppcheck-opensource:main Sep 18, 2024
@firewave
firewave deleted the filesdir-x branch September 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant