Skip to content

Fix #11591 Truncate variable after pre/post increment operator#6331

Merged
chrchr-github merged 4 commits into
cppcheck-opensource:mainfrom
francois-berder:fix-11591
Apr 25, 2024
Merged

Fix #11591 Truncate variable after pre/post increment operator#6331
chrchr-github merged 4 commits into
cppcheck-opensource:mainfrom
francois-berder:fix-11591

Conversation

@francois-berder

Copy link
Copy Markdown
Collaborator

No description provided.

@francois-berder

Copy link
Copy Markdown
Collaborator Author

See bug here.

Comment thread test/testvalueflow.cpp Outdated

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seems good to me. make the ci happy. 👍

Comment thread test/testvalueflow.cpp Outdated
@francois-berder

Copy link
Copy Markdown
Collaborator Author

CI failed for unrelated reasons. Can we launch CI again?

@firewave

Copy link
Copy Markdown
Collaborator

CI failed for unrelated reasons. Can we launch CI again?

No point in that. Microsoft messed up one of their Ubuntu 22.04 repos so those runners are currently broken. See microsoft/linux-package-repositories#130.

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

Comment thread lib/valueflow.cpp Outdated
@chrchr-github chrchr-github merged commit da380ea into cppcheck-opensource:main Apr 25, 2024
@francois-berder francois-berder deleted the fix-11591 branch April 25, 2024 12:52
@francois-berder

Copy link
Copy Markdown
Collaborator Author

Bug report https://trac.cppcheck.net/ticket/11591 should also be updated.

@firewave

firewave commented May 7, 2024

Copy link
Copy Markdown
Collaborator

This introduced a false positive: https://trac.cppcheck.net/ticket/12681.

chrchr-github pushed a commit that referenced this pull request Jun 26, 2024
This PR fixes a similar bug than
[#11591](https://trac.cppcheck.net/ticket/11591) fixed in PR
#6331.

---------

Signed-off-by: Francois Berder <fberder@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants