Skip to content

CI-unixish.yml: removed macos-11 builds and no longer build with qmake on MacOS#5614

Merged
chrchr-github merged 2 commits into
cppcheck-opensource:mainfrom
firewave:macos-qmake
Nov 2, 2023
Merged

CI-unixish.yml: removed macos-11 builds and no longer build with qmake on MacOS#5614
chrchr-github merged 2 commits into
cppcheck-opensource:mainfrom
firewave:macos-qmake

Conversation

@firewave

@firewave firewave commented Nov 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Removed all macos-11 builds as brew no longer supports it and we use it in most steps:

Warning: You are using macOS 11.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

Also brew might no longer provide pre-built Qt5 packages which will cause the step to run for hours as it will compile it on demand - see https://github.com/danmar/cppcheck/actions/runs/6735637341/job/18314354679 for such an instance.

@firewave

firewave commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator Author

We should add macos-13 builds instead but the runner is still in beta: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources.

@firewave

firewave commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator Author

The build which did not finish is now working again so it seems somehow it was pulling some version which did not have packages yet. Still I think the change is fine as we deprecated building via qmake and should move away from it.

@chrchr-github chrchr-github merged commit 9280b5d into cppcheck-opensource:main Nov 2, 2023
@firewave firewave deleted the macos-qmake branch November 2, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @chrchr-github