fixed #11249 (potential hang with -j and --showtime= when using threads) - synchronized access to TimerResults::mResults / added TSAN to CI - #4355
Merged
Conversation
…ds) - synchronized access to `TimerResults::mResults`
… `travis_llvmcheck_suppressions`
firewave
marked this pull request as ready for review
August 12, 2022 14:05
Collaborator
Author
|
FYI I did the incremental commits with pre-comitting the test in f3ae5c0 to verify that TSAN is actually detecting the issue and failing the test before the fix is applied - which it did. It was also detected in the selfcheck but that is just too slow to be enabled. I will re-visit that at a later date. |
This was referenced Aug 15, 2022
Merged
Collaborator
Author
|
@danmar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.