Skip to content

some Python cleanups based on PyCharm inspections - #2999

Merged
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:python
Jan 31, 2021
Merged

some Python cleanups based on PyCharm inspections#2999
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:python

Conversation

@firewave

@firewave firewave commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

The most interesting thing is that some tests which were not run since there were functions with identical names. I tried to give them proper names on what they do and the commit messages but they could probably get more accurate names.

@firewave

Copy link
Copy Markdown
Collaborator Author

test_addon_relative_path now fails since it was never run - somebody needs to have a look at that.

@danmar

danmar commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

test_addon_relative_path now fails since it was never run - somebody needs to have a look at that.

ok great.. I can look at it in a few days.

@firewave

Copy link
Copy Markdown
Collaborator Author

ok great.. I can look at it in a few days.

Thanks. Happy new year!

@danmar

danmar commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

test_addon_relative_path now fails since it was never run - somebody needs to have a look at that.

I think that the stdout output is ok. Could you please tweak the assertion so it ignores/checks that there is an extra Checking helloworld/main.c: SOME_CONFIG...

@firewave
firewave force-pushed the python branch 3 times, most recently from 393401a to c718e57 Compare January 21, 2021 12:09
@firewave
firewave marked this pull request as draft January 21, 2021 13:26
@firewave
firewave marked this pull request as ready for review January 30, 2021 11:56
@firewave

Copy link
Copy Markdown
Collaborator Author

Turns out there was a missing newline in the assert I adjusted.

@firewave

firewave commented Jan 30, 2021

Copy link
Copy Markdown
Collaborator Author

There is a new failure now ...

    def test_compile_commands_unused_function():
        create_unused_function_compile_commands()
        ret, stdout, stderr = cppcheck(['--enable=all', '--error-exitcode=1', '--project=./proj-inline-suppress-unusedFunction/compile_commands.json'])
>       assert ret == 1
E       AssertionError

@danmar Turns out this is also broken on main - please have a look.

@firewave
firewave force-pushed the python branch 2 times, most recently from 54fb5fe to f3622f8 Compare January 30, 2021 14:51
@firewave

firewave commented Jan 30, 2021

Copy link
Copy Markdown
Collaborator Author

If Appveyor and Travis are green this can be merged.

@firewave
firewave merged commit b472b4e into cppcheck-opensource:main Jan 31, 2021
@firewave
firewave deleted the python branch January 31, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants