remove cleanupAfterSimplify from the template simplifier#2998
Conversation
The template simplifier works well enough now so cleanupAfterSimplify is no longer necessary. In fact cleanupAfterSimplify was introducing a bug which improperly simplified C++ style casts. Bugs should be exposed and fixed properly rather than just hiding them.
yes |
|
There's an open issue about wrong simplified types in templates - see https://trac.cppcheck.net/ticket/9675. I was hoping this might have been fixed by this change but unfortunately it is not. |
|
I don't see what's wrong with the output of #9675. We incorporate the template parameters into the function name to make it unique. The output won't compile but that's by design. The output looks like it's still a template function but it's not. We could have changed |
|
I would have expected the output to be void f < const A > Still the varid for If there's nothing wrong please add those comments to the ticket and close it. |
3 participants
The template simplifier works well enough now so cleanupAfterSimplify is
no longer necessary. In fact cleanupAfterSimplify was introducing a bug
which improperly simplified C++ style casts.
Bugs should be exposed and fixed properly rather than just hiding them.