Repository navigation
Fix #9389 ("debug: Executable scope 'x' with unknown function." with … - #2261
Merged
Merged
Conversation
…"using namespace")
Collaborator
Author
|
The failure has nothing to do with this patch: |
danmar
approved these changes
Oct 10, 2019
danmar
left a comment
Collaborator
There was a problem hiding this comment.
looks good.. I just had a small nit.
| } | ||
|
|
||
| namespace { | ||
| std::string qualifiedName(const Scope *scope) |
Collaborator
There was a problem hiding this comment.
Please use static for internal functions. Please feel free to use anonymous namespaces for types. It makes it easier to debug with gdb. I can use break qualifiedName if it's static but not if you use a anonymous namespace.
jubnzv
pushed a commit
to jubnzv/cppcheck
that referenced
this pull request
Nov 13, 2019
cppcheck-opensource#2261) * Fix #9389 ("debug: Executable scope 'x' with unknown function." with "using namespace") * use static rather than anonymous namespace for new functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…"using namespace")