Makefile/dmake: Increase stack size to 8M for Cygwin builds to avoid segfaults#2001
Merged
amai2012 merged 2 commits intoJul 16, 2019
Merged
Conversation
Collaborator
Author
|
Without the increased stack size I get a segmentation fault during the recursive test when running |
Contributor
|
Should we be checking Cygwin builds with CI? |
Collaborator
|
You have to edit tools/dmake.cpp.. but I think the change looks good to me. |
Collaborator
|
yes it sounds like a good idea to check cygwin builds also with CI. |
Collaborator
Author
Oops, forgot that. I will change it. |
Collaborator
Author
|
Appveyor has Cygwin installed, so it is possible to build it there. But I am not sure how easy it is to implement it within the current configuration. |
versat
changed the title
jubnzv
pushed a commit
to jubnzv/cppcheck
that referenced
this pull request
Nov 13, 2019
…segfaults (cppcheck-opensource#2001) * Makefile: Increase stack size to 8M for Cygwin builds to avoid segfaults See cppcheck-opensource#1988 and cppcheck-opensource#1998 * dmake.cpp: Add parameter to CXXFLAGS for increased stack size in Cygwin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1988
and #1998