add support to analyze a specific Visual Studio configuration#1795
add support to analyze a specific Visual Studio configuration#1795fuzzelhjb wants to merge 7 commits into
Conversation
|
I like this idea. It is like an extension to the "Analyze all VS configs". However I do not want to have this option directly on the command line. Just ensure that this option is read in |
|
I made some updates today in the GUI that caused conflicts for this pull request. :-( We'll deal with that later. |
|
Ok no hurry. Would be nice if it can be added in the next official release.
So you would just add it to the GUI and in the cppcheck file format? I think that works also, adding it to the command line was faster without fiddling with QT 😉
Von: Daniel Marjamäki <notifications@github.com>
Gesendet: Mittwoch, 10. April 2019 18:54
An: danmar/cppcheck <cppcheck@noreply.github.com>
Cc: fuzzelhjb <chschmidt9@gmail.com>; Author <author@noreply.github.com>
Betreff: Re: [danmar/cppcheck] add support to analyze a specific Visual Studio configuration (#1795)
I made some updates today in the GUI that caused conflicts for this pull request. :-(
We'll deal with that later.
—
You are receiving this because you authored the thread.
Reply to this email directly, <#1795 (comment)> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/ACE8Q2x4oZtZzpLaizlnaeXKWIJ8TZloks5vfhc7gaJpZM4cmzzX> mute the thread. <https://github.com/notifications/beacon/ACE8Q8hcFn4IgPu-sLNVvymw2smAcTH3ks5vfhc7gaJpZM4cmzzX.gif>
|
yes I agree. If we merge this within a month it should be safe. But after that, I do not know. |
|
Just updated the python html report script with a 'toggle all' button. That is usefull if you deal with a lot of different messages. |
|
please update the python html report in a separate PR. |
For information... I would like that you do this implementation. There is a checkbox in the GUI where you can choose to check all configurations or just 1 configuration. If it's ok with just on/off for you then we do not need to tweak the GUI.. but we need to ensure that this option is used in the command line tool. |
I can see that there is handling for this in the command line tool nowadays. Does it work good enough for you as it is? |
|
How I suppose to do that? I created a new PR but GitHub tries to merge the
old PR with the new one.
Daniel Marjamäki <notifications@github.com> schrieb am Di., 21. Mai 2019,
10:32:
… please update the python html report in a separate PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1795>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQTYQ7HDNHQIC4WOTFNRSDPWOXRBANCNFSM4HE3HTLQ>
.
|
|
hmm it would be a good idea to use a separate branch for each PR. Does this work? |
# Conflicts: # cfg/posix.cfg # lib/templatesimplifier.cpp
|
I close this PR as I believe you no longer need this PR open. |
|
Why this PR has been closed? |
|
@lg2de I still think this sounds like a very useful feature. I suggested that an option is added in the GUI project dialog. That will be required in the long run anyway if we have this feature. And then a command line user can import the GUI project if he wants to use this feature. |
|
@lg2de @fuzzelhjb I have mixed feelings about adding a |
|
Yes, it would be interesting. |
Yes.. but surely you can have 1 extra file for cppcheck configuration somewhere. I don't want to add all possible options in the CLI. When a utility has 1000 command line options it's hard to know if it has the option you need. I like to have a basic set of options on the CLI command line. |
|
I created a new PR with these features. You can use the UI to create a
cppcheck file and there you define the configurations you want to be
analyzed. No new cli command was added just a section in the cppcheck
project file.
Daniel Marjamäki <notifications@github.com> schrieb am Sa., 25. Jan. 2020,
09:57:
… For me the GUI feature is not relevant. I'm using CppCheck only within
build process for SonarQube integration.
Yes.. but surely you can have 1 extra file for cppcheck configuration
somewhere.
I don't want to add all possible options in the CLI. When a utility has
1000 command line options it's hard to know if it has the option you need.
I like to have a basic set of options on the CLI command line.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1795>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQTYQ4SJMYMMJQGBOFOHPDQ7P5FZANCNFSM4HE3HTLQ>
.
|
|
Once your new PR is merged I'll try to add the command line option. This is the feature I need. |
on the command line use --vscfg= to define a Visual Studio configuration that is then used for the analysis.
(e.g. --vscfg="Release|Win32" will only check this configuraton.
In addition to the command line the GUI and the GUI project file .cppcheck was also changed to support this feature from the GUI.