Skip to content

library.cpp: optimized Library::detectContainer()#1778

Merged
danmar merged 2 commits into
cppcheck-opensource:masterfrom
firewave:daca-valgrind
Apr 6, 2019
Merged

library.cpp: optimized Library::detectContainer()#1778
danmar merged 2 commits into
cppcheck-opensource:masterfrom
firewave:daca-valgrind

Conversation

@firewave

@firewave firewave commented Apr 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

reduces Ir from 5882 to 1149 according to callgrind

I chose the random package nn for profiling.

@firewave
library.cpp: optimized Library::detectContainer()
d08a78f 
reduces Ir from 5882 to 1149 according to callgrind
@versat

versat commented Apr 4, 2019

Copy link
Copy Markdown
Collaborator

The tests in Travis hang at this test:

...
TestSymbolDatabase::executableScopeWithUnknownFunction
TestSymbolDatabase::valuetype

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

Does make check work locally? Maybe there is a problem when -O2 is used or so.

@danmar danmar merged commit 16ebb90 into cppcheck-opensource:master Apr 6, 2019
@firewave firewave deleted the daca-valgrind branch September 20, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@firewave @versat @danmar