Skip to content

Fix 8124: False positive va_end missing with lambda#1577

Merged
danmar merged 1 commit into
cppcheck-opensource:masterfrom
rikardfalkeborn:8124-va_list-fp-with-lambdas
Jan 10, 2019
Merged

Fix 8124: False positive va_end missing with lambda#1577
danmar merged 1 commit into
cppcheck-opensource:masterfrom
rikardfalkeborn:8124-va_list-fp-with-lambdas

Conversation

@rikardfalkeborn

Copy link
Copy Markdown
Contributor

Skip lambdas, to avoid false positives due to possible
return statements in lambdas.

@rikardfalkeborn rikardfalkeborn force-pushed the 8124-va_list-fp-with-lambdas branch from 87bd443 to 9785c3d Compare January 8, 2019 20:44
@rikardfalkeborn rikardfalkeborn changed the title Fix 8124: False positive with vaarg and lambda Fix 8124: False positive va_end missing with lambda Jan 8, 2019
@amai2012

amai2012 commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

Adding another include requires an update of the Makefile (see https://travis-ci.org/danmar/cppcheck/jobs/477029177).
Do you develop on a linux/unix platform? Then please re-run dmake and also update the Makefile. Otherwise somebody else will do later...

@rikardfalkeborn

Copy link
Copy Markdown
Contributor Author

Yes I develop on Linux, I'll take a look at it soon. Do I need to update something else (vs project, cmake)?

@amai2012

amai2012 commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

Yes I develop on Linux, I'll take a look at it soon. Do I need to update something else (vs project, cmake)?

No, just make dmake && ./dmake

Skip lambdas, to avoid false positives due to possible
return statements in lambdas.

Also, run dmake.
@rikardfalkeborn rikardfalkeborn force-pushed the 8124-va_list-fp-with-lambdas branch from 9785c3d to 362cb83 Compare January 9, 2019 12:45
@amai2012 amai2012 requested a review from danmar January 10, 2019 07:24
@danmar

danmar commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

Thanks!

@danmar danmar merged commit a48c8ab into cppcheck-opensource:master Jan 10, 2019
@rikardfalkeborn rikardfalkeborn deleted the 8124-va_list-fp-with-lambdas branch January 10, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants