Skip to content

Commit dbc19d6

Browse files
danmardanmar
committed
GUI: Renamed private variables
1 parent 7d00b30 commit dbc19d6

2 files changed

Lines changed: 23 additions & 23 deletions

File tree

‎gui/librarydialog.cpp‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class FunctionListItem : public QListWidgetItem {
4747
LibraryDialog::LibraryDialog(QWidget *parent) :
4848
QDialog(parent),
4949
mUi(new Ui::LibraryDialog),
50-
ignoreChanges(false)
50+
mIgnoreChanges(false)
5151
{
5252
mUi->setupUi(this);
5353
mUi->buttonSave->setEnabled(false);
@@ -112,22 +112,22 @@ void LibraryDialog::openCfg()
112112
return;
113113
}
114114

115-
ignoreChanges = true;
116-
data.swap(tempdata);
115+
mIgnoreChanges = true;
116+
mData.swap(tempdata);
117117
mFileName = selectedFile;
118118
mUi->buttonSave->setEnabled(false);
119119
mUi->buttonSaveAs->setEnabled(true);
120120
mUi->filter->clear();
121121
mUi->functions->clear();
122-
for (CppcheckLibraryData::Function &function : data.functions) {
122+
for (CppcheckLibraryData::Function &function : mData.functions) {
123123
mUi->functions->addItem(new FunctionListItem(mUi->functions,
124124
&function,
125125
false));
126126
}
127-
mUi->sortFunctions->setEnabled(!data.functions.empty());
128-
mUi->filter->setEnabled(!data.functions.empty());
127+
mUi->sortFunctions->setEnabled(!mData.functions.empty());
128+
mUi->filter->setEnabled(!mData.functions.empty());
129129
mUi->addFunction->setEnabled(true);
130-
ignoreChanges = false;
130+
mIgnoreChanges = false;
131131
}
132132

133133
void LibraryDialog::saveCfg()
@@ -137,7 +137,7 @@ void LibraryDialog::saveCfg()
137137
QFile file(mFileName);
138138
if (file.open(QIODevice::WriteOnly | QIODevice::Text)) {
139139
QTextStream ts(&file);
140-
ts << data.toString() << '\n';
140+
ts << mData.toString() << '\n';
141141
mUi->buttonSave->setEnabled(false);
142142
} else {
143143
QMessageBox msg(QMessageBox::Critical,
@@ -181,18 +181,18 @@ void LibraryDialog::addFunction()
181181
arg.nr = i;
182182
f.args.append(arg);
183183
}
184-
data.functions.append(f);
185-
mUi->functions->addItem(new FunctionListItem(mUi->functions, &data.functions.back(), false));
184+
mData.functions.append(f);
185+
mUi->functions->addItem(new FunctionListItem(mUi->functions, &mData.functions.back(), false));
186186
mUi->buttonSave->setEnabled(true);
187-
mUi->sortFunctions->setEnabled(!data.functions.empty());
188-
mUi->filter->setEnabled(!data.functions.empty());
187+
mUi->sortFunctions->setEnabled(!mData.functions.empty());
188+
mUi->filter->setEnabled(!mData.functions.empty());
189189
}
190190
delete d;
191191
}
192192

193193
void LibraryDialog::editFunctionName(QListWidgetItem* item)
194194
{
195-
if (ignoreChanges)
195+
if (mIgnoreChanges)
196196
return;
197197
QString functionName = item->text();
198198
CppcheckLibraryData::Function * const function = dynamic_cast<FunctionListItem*>(item)->function;
@@ -201,9 +201,9 @@ void LibraryDialog::editFunctionName(QListWidgetItem* item)
201201
function->name = functionName;
202202
mUi->buttonSave->setEnabled(true);
203203
} else {
204-
ignoreChanges = true;
204+
mIgnoreChanges = true;
205205
item->setText(function->name);
206-
ignoreChanges = false;
206+
mIgnoreChanges = false;
207207
}
208208
}
209209
}
@@ -232,7 +232,7 @@ void LibraryDialog::selectFunction()
232232
return;
233233
}
234234

235-
ignoreChanges = true;
235+
mIgnoreChanges = true;
236236
mUi->comments->setPlainText(function->comments);
237237
mUi->comments->setEnabled(true);
238238

@@ -249,25 +249,25 @@ void LibraryDialog::selectFunction()
249249
mUi->arguments->setEnabled(true);
250250

251251
mUi->editArgButton->setEnabled(true);
252-
ignoreChanges = false;
252+
mIgnoreChanges = false;
253253
}
254254

255255
void LibraryDialog::sortFunctions(bool sort)
256256
{
257257
if (sort) {
258258
mUi->functions->sortItems();
259259
} else {
260-
ignoreChanges = true;
260+
mIgnoreChanges = true;
261261
CppcheckLibraryData::Function *selfunction = currentFunction();
262262
mUi->functions->clear();
263-
for (CppcheckLibraryData::Function &function : data.functions) {
263+
for (CppcheckLibraryData::Function &function : mData.functions) {
264264
mUi->functions->addItem(new FunctionListItem(mUi->functions,
265265
&function,
266266
selfunction == &function));
267267
}
268268
if (!mUi->filter->text().isEmpty())
269269
filterFunctions(mUi->filter->text());
270-
ignoreChanges = false;
270+
mIgnoreChanges = false;
271271
}
272272
}
273273

@@ -288,7 +288,7 @@ void LibraryDialog::filterFunctions(QString filter)
288288

289289
void LibraryDialog::changeFunction()
290290
{
291-
if (ignoreChanges)
291+
if (mIgnoreChanges)
292292
return;
293293

294294
CppcheckLibraryData::Function *function = currentFunction();

‎gui/librarydialog.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ private slots:
5353

5454
private:
5555
Ui::LibraryDialog *mUi;
56-
CppcheckLibraryData data;
56+
CppcheckLibraryData mData;
5757
QString mFileName;
58-
bool ignoreChanges;
58+
bool mIgnoreChanges;
5959

6060
static QString getArgText(const CppcheckLibraryData::Function::Arg &arg);
6161
CppcheckLibraryData::Function *currentFunction();

0 commit comments

Comments
 (0)