fixed a problem that causes a memory leak. We are passing user, pass,

rdiazmartin · rdiazmartin · commit e53d066628af · 2016-11-07T15:50:39.000+01:00
and digested_user as char pointers by value which causes the original
pointers be always null when they are going to be free in
complete_request, now we pass them by reference and everything works
fine
diff --git a/src/httpserver/webserver.hpp b/src/httpserver/webserver.hpp
@@ -328,7 +328,7 @@ class webserver
 
         void end_request_construction(MHD_Connection* connection,
                 struct details::modded_request* mr, const char* version,
-                const char* method, char* user, char* pass, char* digested_user
+                const char* method, char* &user, char* &pass, char* &digested_user
         );
 
         int finalize_answer(MHD_Connection* connection,
diff --git a/src/webserver.cpp b/src/webserver.cpp
@@ -964,9 +964,9 @@ void webserver::end_request_construction(
         struct details::modded_request* mr,
         const char* version,
         const char* method,
-        char* user,
-        char* pass,
-        char* digested_user
+        char* &user,
+        char* &pass,
+        char* &digested_user
 )
 {
     mr->ws = this;

Original file line number	Diff line number	Diff line change
`@@ -964,9 +964,9 @@ void webserver::end_request_construction(`
`964`	`964`	`struct details::modded_request* mr,`
`965`	`965`	`const char* version,`
`966`	`966`	`const char* method,`
`967`		`- char* user,`
`968`		`- char* pass,`
`969`		`- char* digested_user`
	`967`	`+ char* &user,`
	`968`	`+ char* &pass,`
	`969`	`+ char* &digested_user`
`970`	`970`	`)`
`971`	`971`	`{`
`972`	`972`	`mr->ws = this;`