For a POST parameter with a large value, libmicrohttpd will call webserver::post_iterator

pellucide · pellucide · commit c2c9656cd47a · 2016-03-24T16:50:04.000-04:00
multiple times with chunnks of post data and successibe offsets. Currently, set_arg will
overwrites the value. So after all the successive post_iterator calls, the value will be
set to the last chunk.

This change fixes the set_arg() function(s).. by checking for existing value and appending to it
than overwriting it.
diff --git a/src/httpserver/http_request.hpp b/src/httpserver/http_request.hpp
@@ -442,7 +442,11 @@ class http_request
         **/
         void set_arg(const std::string& key, const std::string& value)
         {
-            this->args[key] = value;
+            if (this->args[key].empty()) {
+                this->args[key] = value;
+            } else {
+                this->args[key].append(value);
+            }
         }
         /**
          * Method used to set an argument value by key.
@@ -452,7 +456,11 @@ class http_request
         **/
         void set_arg(const char* key, const char* value, size_t size)
         {
-            this->args[key] = std::string(value, size);
+            if (this->args[key].empty()) {
+                this->args[key] = std::string(value, size);
+            } else {
+                this->args[key].append(value, size);
+            }
         }
         /**
          * Method used to set the content of the request
