Remove needless exception

etr · etr · commit 6826ba8ee487 · 2018-12-23T08:26:47.000Z
diff --git a/src/http_endpoint.cpp b/src/http_endpoint.cpp
@@ -92,7 +92,7 @@ webserver::http_endpoint::http_endpoint
         }
 
         if((parts[i].size() < 3) || (parts[i][0] != '{') || (parts[i][parts[i].size() - 1] != '}'))
-            throw webserver::http_endpoint::bad_http_endpoint();
+            throw std::invalid_argument("Bad URL format");
 
         std::string::size_type bar = parts[i].find_first_of('|');
         this->url_pars.push_back(parts[i].substr(1, bar != string::npos ? bar - 1 : parts[i].size() - 2));
diff --git a/src/httpserver/http_endpoint.hpp b/src/httpserver/http_endpoint.hpp
@@ -29,6 +29,7 @@
 #include <utility>
 #include <regex.h>
 #include <string>
+#include <stdexcept>
 
 #include "webserver.hpp"
 
@@ -38,33 +39,12 @@ namespace httpserver
 class webserver;
 class http_resource;
 
-namespace details
-{
-
-/**
- * Exception class throwed when a bad formatted http url is used
-**/
-
-};
-
 /**
  * Class representing an Http Endpoint. It is an abstraction used by the APIs.
 **/
 class webserver::http_endpoint
 {
     public:
-        class bad_http_endpoint : public std::exception
-        {
-            /**
-             * Method used to see error details
-             * @return a const char* containing the error message
-            **/
-            virtual const char* what() const throw()
-            {
-                return "Bad url format!";
-            }
-        };
-
         /**
          * Copy constructor. It is useful expecially to copy regex_t structure that contains dinamically allocated data.
          * @param h The http_endpoint to copy

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ webserver::http_endpoint::http_endpoint`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`if((parts[i].size() < 3) \|\| (parts[i][0] != '{') \|\| (parts[i][parts[i].size() - 1] != '}'))`
`95`		`- throw webserver::http_endpoint::bad_http_endpoint();`
	`95`	`+ throw std::invalid_argument("Bad URL format");`
`96`	`96`
`97`	`97`	`std::string::size_type bar = parts[i].find_first_of('\|');`
`98`	`98`	`this->url_pars.push_back(parts[i].substr(1, bar != string::npos ? bar - 1 : parts[i].size() - 2));`