Change methods to declare constness of returns

etr · etr · commit 27b230ab77e7 · 2018-12-08T02:34:19.000Z
diff --git a/src/httpserver/string_utilities.hpp b/src/httpserver/string_utilities.hpp
@@ -39,12 +39,12 @@ namespace string_utilities
  * @param str The string to turn uppercase
  * @return a string that is the uppercase version of the previous
 **/
-std::string to_upper_copy(const std::string& str);
-std::string to_lower_copy(const std::string& str);
-std::vector<std::string> string_split(const std::string& s,
+const std::string to_upper_copy(const std::string& str);
+const std::string to_lower_copy(const std::string& str);
+const std::vector<std::string> string_split(const std::string& s,
         char sep = ' ', bool collapse = true
 );
-std::string regex_replace(const std::string& str, const std::string& pattern,
+const std::string regex_replace(const std::string& str, const std::string& pattern,
         const std::string& replace_str
 );
 void to_upper(std::string& str);
diff --git a/src/string_utilities.cpp b/src/string_utilities.cpp
@@ -34,7 +34,7 @@ namespace httpserver
 namespace string_utilities
 {
 
-std::string to_upper_copy(const std::string& str)
+const std::string to_upper_copy(const std::string& str)
 {
     std::string result = str;
     std::transform(result.begin(),
@@ -55,7 +55,7 @@ void to_upper(std::string& str)
     );
 }
 
-std::string to_lower_copy(const std::string& str)
+const std::string to_lower_copy(const std::string& str)
 {
     std::string result = str;
     std::transform(result.begin(),
@@ -67,7 +67,7 @@ std::string to_lower_copy(const std::string& str)
     return result;
 }
 
-std::vector<std::string> string_split(
+const std::vector<std::string> string_split(
         const std::string& s,
         char sep,
         bool collapse
@@ -84,7 +84,7 @@ std::vector<std::string> string_split(
     return result;
 }
 
-std::string regex_replace(const std::string& str,
+const std::string regex_replace(const std::string& str,
         const std::string& pattern,
         const std::string& replace_str
 )

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ namespace httpserver`
`34`	`34`	`namespace string_utilities`
`35`	`35`	`{`
`36`	`36`
`37`		`-std::string to_upper_copy(const std::string& str)`
	`37`	`+const std::string to_upper_copy(const std::string& str)`
`38`	`38`	`{`
`39`	`39`	`std::string result = str;`
`40`	`40`	`std::transform(result.begin(),`
`@@ -55,7 +55,7 @@ void to_upper(std::string& str)`
`55`	`55`	`);`
`56`	`56`	`}`
`57`	`57`
`58`		`-std::string to_lower_copy(const std::string& str)`
	`58`	`+const std::string to_lower_copy(const std::string& str)`
`59`	`59`	`{`
`60`	`60`	`std::string result = str;`
`61`	`61`	`std::transform(result.begin(),`
`@@ -67,7 +67,7 @@ std::string to_lower_copy(const std::string& str)`
`67`	`67`	`return result;`
`68`	`68`	`}`
`69`	`69`
`70`		`-std::vector<std::string> string_split(`
	`70`	`+const std::vector<std::string> string_split(`
`71`	`71`	`const std::string& s,`
`72`	`72`	`char sep,`
`73`	`73`	`bool collapse`
`@@ -84,7 +84,7 @@ std::vector<std::string> string_split(`
`84`	`84`	`return result;`
`85`	`85`	`}`
`86`	`86`
`87`		`-std::string regex_replace(const std::string& str,`
	`87`	`+const std::string regex_replace(const std::string& str,`
`88`	`88`	`const std::string& pattern,`
`89`	`89`	`const std::string& replace_str`
`90`	`90`	`)`