Skip to content

Base classes should have virtual destructors #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appkins merged 1 commit into from
Jan 27, 2020
Merged

Base classes should have virtual destructors #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions includes/cpp_redis/impl/types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ namespace cpp_redis {
class serializer_type {
public:
inline serializer_type() {}

virtual ~serializer_type() {}

/**
* @return the underlying string
Expand All @@ -62,6 +64,8 @@ typedef std::shared_ptr<serializer_type> serializer_ptr_t;
template <typename T>
class message_impl {
public:
virtual ~message_impl() {}

virtual const std::string get_id() const = 0;

virtual const message_impl& set_id(std::string id) = 0;
Expand Down