Skip to content

Default http server connection buffer size #726

Closed

Description

@carun

I am on branch 0.1.13-release.
I see that the default BOOST_NETWORK_HTTP_SERVER_CONNECTION_BUFFER_SIZE is 1024 bytes.

I did some tests (by uploading 250 MB of file) and I see that setting it to 8192 bytes increases the transfer rate by 7 folds. With 4096, the transfer rate is increased by close to 5 folds. The test code is in here

Can we increase the default value of BOOST_NETWORK_HTTP_SERVER_CONNECTION_BUFFER_SIZE to 8192 bytes or may be 4096 bytes (for memory constrained systems)? (Few KB's shouldn't matter, I guess).

Activity

  1. carun commented on Mar 31, 2017

    @carun
    Author

    @deanberris Can you please suggest?

  2. deanberris commented on Apr 5, 2017

    @deanberris
    Member

    I thought I responded to this but I can see that I hadn't. ☹️

    I'm fine with increasing the default. I'd also consider making this a value that's configurable through the HTTP server options, and use the macro to define the default.

    Happy to review a pull request that changes it to 4K to begin with.

    Thanks @carun for the testing and suggestion!

  3. carun commented on Apr 6, 2017

    @carun
    Author

    PR on the way. hg user here. Banging my head against this damn git CLI! git reset is probably the worst command in the history of computing. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions