Skip to content

multiple definitions of swap from thread_pool.hpp #643

Closed

Description

@Plaristote

Greetings !

In boost/network/utils/thread_pool.hpp, line 101, there's global swap function that gets declared. The problem is, it's not inline, and the compiler complains about multiple definition for each target that includes thread_pool.hpp.

Seeing the history, this function used to be a template, 20 days ago or so. As a template, this issue wouldn't happen: but as a global function, we have to either declare it as inline, or define it away from the headers.
As far as I know, there's no other way to go around that.

Activity

  1. self-assigned this
    on Apr 25, 2016
  2. deanberris commented on Apr 25, 2016

    @deanberris
    Member

    Oops. You're right. I'm fine with making it inline. I'll get to this soon enough.

  3. deanberris commented on Apr 25, 2016

    @deanberris
    Member

    @Plaristote -- this is in the master branch, yes?

  4. added a commit that references this issue on Apr 25, 2016
    340e242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions