You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
async_connection: read function calls callback with too few parameters #635
The read function from async_connection calls the read_callback_function with 2 instead of 4 needed parameters, this leads into this compiling issue (when using the read function):
async_connection.hpp | 395 |
error: no match for call to ‘(const read_callback_function {aka const std::function<void(boost::iterator_range<const char*>, std::error_code, long unsigned int, std::shared_ptr<boost::network::http::async_connection<boost::network::http::tags::http_server, {anonymous}::serverhandle> >)>}) (std::error_code&, size_t&)’|
To say this is a pretty huge bug is kind of an understatement (all reading of request bodies for servers broken) - maybe there should be a 0.12.1 release for this fix?
Activity
susnux commentedon Apr 19, 2016
I am not sure, but I think something like this should work (?)
Fixes #635 - bug in async server's connection read
Merge pull request #637 from deanberris/topic/fix-async-server
susnux commentedon Apr 20, 2016
Question: Are the fixes also going to be merged back into master?
deanberris commentedon Apr 21, 2016
@susnux It should be, I'll cherry-pick it in soon.
Fixes #635 - bug in async server's connection read
MMOSimca commentedon Apr 23, 2016
To say this is a pretty huge bug is kind of an understatement (all reading of request bodies for servers broken) - maybe there should be a 0.12.1 release for this fix?
susnux commentedon Apr 23, 2016
I think @deanberris (?) is working on a bugfix release 0.12.1
Fixes #635 - bug in async server's connection read