Skip to content

Including Boost.Asio before cpp-netlib causes compile error #634

Closed

Description

@amerry

If I do something like

#include <boost/asio/ip/address.hpp>
#include <boost/network.hpp>

then compilation fails because the references to things like asio::io_service in cpp-netlib resolve to the boost::asio namespace (since the code is in the boost::network namespace).

While I can just reorder the headers, this is still not an ideal situation. Presumably, this could be solved by using absolute references, like ::asio::io_service.

Activity

  1. self-assigned this
    on Apr 15, 2016
  2. deanberris commented on Apr 18, 2016

    @deanberris
    Member

    Yes, this is bad. I see @glynos has taken this on.

    Do you mind fixing this in the 0.12-release branch too so that we can release a 0.12.1 soon to remedy this?

  3. glynos commented on Apr 20, 2016

    @glynos
    Member

    @amerry Could you check that the latest changes work for you?

  4. amerry commented on Apr 26, 2016

    @amerry
    Author

    Yep, 0.12-release now works.

  5. avalchev commented on Apr 29, 2016

    @avalchev

    Could you please merge it into master.

  6. glynos commented on Apr 29, 2016

    @glynos
    Member

    @avalchev These changes were already committed on master in a separate PR:

    f2095b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions