Skip to content

Missing HTTPS use documentation. #429

Open

Description

@povilasb

I'm using 0.11-devel branch commit bd0cf0b (latest by the time I opened this issue).

I wrote a basic sample for HTTPS request:

#define BOOST_NETWORK_ENABLE_HTTPS
#include <boost/network/protocol/http/client.hpp>

namespace net = boost::network;
namespace http = net::http;

http::client::request request("https://mano.labas.lt/lt/selfcare");
request << net::header("Connection", "close");
http::client client_;
http::client::response response = client_.get(request);
std::string body_ = http::body(response);

std::cout << body_ << '\n';

The problem is that there was no documentation about #define BOOST_NETWORK_ENABLE_HTTPS. At least i couldn't find one. I found it on https://groups.google.com/forum/#!topic/cpp-netlib/M8LIz9ahMLo.

So my request would be to include this info in HTTP/HTTPS client documentation.

Activity

  1. self-assigned this
    on Aug 30, 2014
  2. deanberris commented on Aug 30, 2014

    @deanberris
    Member

    Oh, yes. That's not good. I'll add something to the documentation for 0.11.1.

  3. added this to the 0.11.1 milestone on Aug 30, 2014
  4. deanberris commented on Sep 1, 2014

    @deanberris
    Member

    @povilasb -- do you mind reviewing #432 before @glynos merges it in? Do the changes make sense?

    Thanks in advance!

  5. povilasb commented on Sep 1, 2014

    @povilasb
    Author

    deanberris@eff6ea7

    I've left two comments.

    Cheers.

  6. added a commit that references this issue on Sep 2, 2014
    3482012
  7. added a commit that references this issue on Apr 14, 2015
    3b7c544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions