Closed
Conversation
2bndy5
reviewed
Apr 22, 2024
2bndy5
previously requested changes
Apr 22, 2024
Collaborator
There was a problem hiding this comment.
Just to be clear, this may not cache the clang-format nor clang-tidy executables.
Important
This might actually cache the executables on MacOS or Windows because our cpp-linter/clang-tools-pip tool will fall back to installing clang tools (static) binaries to the same directory that the python executable is located.
In the case of a venv, that default install location is /.env/Scripts/ on Windows or /.env/bin/ on MacOS (~/.local/bin/ on linux).
Collaborator
|
FYI, I think the CI failed on MacOS runners because of segfaults. This isn't anything to do with the changes here, rather we should look into this separately. |
Collaborator
|
I guess we should also cache pip's global cache as well if this new option is enabled. |
2bndy5
reviewed
Apr 22, 2024
2bndy5
reviewed
Apr 22, 2024
Unity-Billal-mesloub
pushed a commit
to Unity-Billal-mesloub/cpp-linter-action
that referenced
this pull request
Jan 18, 2026
* migrate to uv v0.8.9 resolves cpp-linter#305 * use nu shell (cross-platform compatible) * enable caching by default closes cpp-linter#234 *update RTD config * pin to external actions' via commit hash * use colored logs as progress markers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hashFilescurrently doesn't support globs outside of the GITHUB_WORKSPACE. This works around the limitation.