style: use PEP604 typing syntax #187

2bndy5 · 2026-02-06T07:42:38Z

See PEP604 which was adopted/preferred as of Python 3.10.

follow-up to build: drop python 3.9 #186

Summary by CodeRabbit

Refactor
- Modernized type annotations across the codebase to use newer Python union and generic syntax (PEP 604/585). No runtime behavior changes; improves maintainability and type-checking.
Tests
- Updated test type annotations to match the new typing style. No test logic changes.

codecov · 2026-02-06T07:55:50Z

Codecov Report

❌ Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.30%. Comparing base (2f02972) to head (1edb6cf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cpp_linter/common_fs/__init__.py	92.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files          24       24              
  Lines        1947     1942       -5     
==========================================
- Hits         1914     1909       -5     
  Misses         33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

See [PEP604] which was adopted/preferred as of Python 3.10. [PEP604]: https://peps.python.org/pep-0604/

coderabbitai · 2026-02-06T08:41:18Z

Walkthrough

This PR modernizes type annotations project-wide, replacing typing module aliases (List, Dict, Optional, Union, Tuple) with Python 3.9+ built-in generics (list, dict, tuple) and PEP 604 union syntax (X | None), updating signatures, attributes, and test annotations accordingly.

Changes

Cohort / File(s)	Summary
Clang Tools Core `cpp_linter/clang_tools/__init__.py`, `cpp_linter/clang_tools/clang_format.py`, `cpp_linter/clang_tools/clang_tidy.py`, `cpp_linter/clang_tools/patcher.py`	Replaced typing aliases with built-in generics and PEP 604 unions across public APIs, class attributes and function signatures (e.g., `Optional[T]` → `T
File System & Filtering `cpp_linter/common_fs/__init__.py`, `cpp_linter/common_fs/file_filter.py`	Modernized FileObj and FileFilter type hints (lists of ints, ranges, diff chunks, optional advice types) to built-in generics and union syntax; updated method signatures/returns accordingly.
Git Integration `cpp_linter/git/__init__.py`, `cpp_linter/git/git_str.py`	Converted get_sha/get_diff/parse_diff/parse_patch signatures and internal annotations to built-in generics and PEP 604 unions; adjusted some commit/peel usages and parse error casting formatting.
REST API Layer `cpp_linter/rest_api/__init__.py`, `cpp_linter/rest_api/github_api.py`	Updated RestApiClient and GitHub API method signatures, payload typings, and internal list/dict annotations to `list[...]`, `dict[...]`, and union syntax for optional params/returns.
CLI Configuration `cpp_linter/cli.py`	Replaced typing aliases in Args dataclass and parser helpers with built-in generics and union syntax (e.g., `diff_base`, `extensions`, `jobs`, `_parser_args`, `_parse_jobs`).
Tests `tests/capture_tools_output/`, `tests/ignored_paths/`, `tests/test_cli_args.py`, `tests/test_misc.py`, `tests/test_rate_limits.py`	Harmonized test parameter and local type hints to built-in generics and union syntax; no behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

build: drop python 3.9 #186: Wholesale migration of type hints to PEP 604 and built-in generics—overlaps with the typing modernization in this PR.
feat: capture and output clang version used #124: Changes to ClangVersions and capture_clang_tools_output signatures and plumbing clang version data are directly related to updates in clang_tools here.

Suggested labels

enhancement

Suggested reviewers

shenxianpeng

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 69.77% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main objective: updating the codebase to use PEP 604 typing syntax (union operator \|) instead of older Optional/Union imports from the typing module.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch pep604-typing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

does not bump any deps though; just removes old locks related to python 3.9

2bndy5 mentioned this pull request Feb 6, 2026

perf: small optimizations to get_diff() #185

Merged

style: use PEP604 typing syntax

8be3a64

See [PEP604] which was adopted/preferred as of Python 3.10. [PEP604]: https://peps.python.org/pep-0604/

2bndy5 force-pushed the pep604-typing branch from 4e58823 to 8be3a64 Compare February 6, 2026 08:37

2bndy5 marked this pull request as ready for review February 6, 2026 08:37

This comment was marked as duplicate.

Sign in to view

This comment was marked as resolved.

Sign in to view

2bndy5 added 2 commits February 6, 2026 00:55

revise cli.py

5690278

update lock file

1edb6cf

does not bump any deps though; just removes old locks related to python 3.9

cpp-linter deleted a comment from coderabbitai bot Feb 6, 2026

2bndy5 merged commit 9a5897a into main Feb 6, 2026
43 checks passed

2bndy5 deleted the pep604-typing branch February 6, 2026 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

style: use PEP604 typing syntax #187

style: use PEP604 typing syntax #187

Uh oh!

2bndy5 commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

codecov bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

style: use PEP604 typing syntax #187

style: use PEP604 typing syntax #187

Uh oh!

Conversation

2bndy5 commented Feb 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

codecov bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

2bndy5 commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

codecov bot commented Feb 6, 2026 •

edited

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading