MD: Refactor REFTRAJ / EVAL_ENERGY_FORCES keyword #2981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the two confusing logical keywords EVAL_ENERGY_FORCES and EVAL_FORCES with a single enum keyword that has three options:
NONE: Evaluate nothingENERGY: Evaluate only the energyENERGY_FORCES: Evaluate energy and forcesThe old keywords are marked as deprecated, but still work to retain backwards compatibility.
See also #2974, #894, and https://groups.google.com/g/cp2k/c/40BM0xIXak8/m/NtJ9iYb7BAAJ.