Skip to content

Conversation

@glb96
Copy link
Contributor

@glb96 glb96 commented Apr 20, 2023

Creates a print RTP routine to compute the projection of TD MO on reference one.
The reference MOs can be from SCF calculation (by default the one from which the RTP starts) or XAS_TDP.
A regtest has been added in the XAS_TDP folder in order to test the reading of .wfn obtained from XAS_TDP module as the reference MO to project on.

@glb96 glb96 force-pushed the master branch 2 times, most recently from 48053a0 to a8ff55f Compare April 20, 2023 18:47
@glb96 glb96 marked this pull request as ready for review April 20, 2023 19:14
Copy link
Member

@oschuett oschuett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few minor comments.

I really like your well written error messages. They make such a difference for usability.

@glb96
Copy link
Contributor Author

glb96 commented Apr 21, 2023

Thanks for your help! I have pushed an updated version with your advice.

* new file for input section

* uptpdate (#24)

* RTP: Fix restart for velocity gauge

* Parallel Jacobi Rotations for IAO bonds (cp2k#2714)

* Create README.md

* Update README.md

* make pretty

---------

Co-authored-by: Juerg Hutter <hutter@chem.uzh.ch>
Co-authored-by: Matthias Krack <matthias.krack@psi.ch>

* save ungoing work

* save ungoing work 2

* input section seems to work

* before reading restart files

* before reading restart files2

* before reading restart files3

* save

* reading seems okay, moving toward projection part

* save

* compiles but problem memory for /users/glebreton/Software/cp2k/src/emd/rt_propagation_output.F:251. Run Own_test/Projection/Proj

* working!

* seems to work fine. All SCF implementation completed.

* fixing dummy indices problems.

* First working implementation for reading XAS .wfn files

---------

Co-authored-by: Juerg Hutter <hutter@chem.uzh.ch>
Co-authored-by: Matthias Krack <matthias.krack@psi.ch>

Projection mo rtp (#31)

* new file for input section

* uptpdate (#24)

* RTP: Fix restart for velocity gauge

* Parallel Jacobi Rotations for IAO bonds (cp2k#2714)

* Create README.md

* Update README.md

* make pretty

---------

Co-authored-by: Juerg Hutter <hutter@chem.uzh.ch>
Co-authored-by: Matthias Krack <matthias.krack@psi.ch>

* save ungoing work

* save ungoing work 2

* input section seems to work

* before reading restart files

* before reading restart files2

* before reading restart files3

* save

* reading seems okay, moving toward projection part

* save

* compiles but problem memory for /users/glebreton/Software/cp2k/src/emd/rt_propagation_output.F:251. Run Own_test/Projection/Proj

* working!

* seems to work fine. All SCF implementation completed.

* fixing dummy indices problems.

* First working implementation for reading XAS .wfn files

* fix name error

---------

Co-authored-by: Juerg Hutter <hutter@chem.uzh.ch>
Co-authored-by: Matthias Krack <matthias.krack@psi.ch>

fix

new tests

make pretty

fix

typo

typo

ok

fixing errors

typo
@oschuett oschuett merged commit 3afc380 into cp2k:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants