Skip to content

Conversation

@mhayter
Copy link
Contributor

@mhayter mhayter commented Aug 26, 2025

P.S. Should it be labeled 0/1 Knapsack and not 0-1 Knapsack?

P.S. Should it be labeled 0/1 Knapsack and not 0-1 Knapsack?
@spike1236
Copy link
Member

I also think that it's better to rename it to 0/1 Knapsack

Copy link
Member

@spike1236 spike1236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0-1 -> 0/1?

@mhayter
Copy link
Contributor Author

mhayter commented Sep 3, 2025

Lol I literally left the question as a an open discussion. The title of the actual article uses this convention. I pretty sure that the article consistently uses that convention. We're blocking merging for a change that I did not make?

@adamant-pwn
Copy link
Member

adamant-pwn commented Sep 3, 2025

Uhh, I feel like the discussion itself is a bit of a bike shedding (as in, it doesn't really matter which way we name it).

Nevertheless, scholarly publications seem to use "0-1 knapsack": 1, 2, 3, 4. Unless anyone feel strongly about renaming (and can provide solid reasoning for it), I'd leave the name as is.

@spike1236
Copy link
Member

spike1236 commented Sep 3, 2025

Sorry, of course I didn't mean to block the PR. I just thought it was valid change to rename 0-1 to 0/1 because I googled the topic and in most cases, it appeared as 0/1 knapsack. So my review was meant to just commit the name change🙌
But, I agree with adamant - there's not much difference in how the topic is named, so both options are valid

@spike1236 spike1236 dismissed their stale review September 3, 2025 20:05

Both 0/1 and 0-1 are valid

@mhayter
Copy link
Contributor Author

mhayter commented Sep 4, 2025

It sounds like we're leaving it then and can merge?

@spike1236 spike1236 merged commit 0e77dbf into main Sep 21, 2025
3 checks passed
@spike1236 spike1236 deleted the mhayter-patch-2 branch September 21, 2025 22:37
github-actions bot added a commit that referenced this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants