[Backport release-1.5] fix(kubevirt-instancetypes): drop persistent EFI/TPM to unblock live-migration - #3016
Merged
Conversation
…migration TEMPORARY revert. Restoring persistent EFI/TPM state (4cc60e3) makes windows.11/2k22/2k25 VMs get a backend-storage PVC that is ReadWriteOnce on the default StorageClass, which pins the VM to its node and blocks live-migration and node drains (with evictionStrategy: LiveMigrate this can stall cluster upgrades). See #3005. Strip persistent EFI/TPM from the preferences again, but with `yq del` so an emptied preferredTPM stays `{}` (the v1.8 CRD rejects null) — the bug the original sed strip caused. Secure Boot and the vTPM stay present, just non-persistent. Stopgap until vm-state can request an RWX backend (RWX-Block via the upstream KubeVirt change, or an RWX-Filesystem vmStateStorageClass). Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Andrei Kvapil <andrei.kvapil@aenix.io> (cherry picked from commit 6ac2601)
dosubot
Bot
added
area/virtualization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3006 to
release-1.5.