Checking in change that has been sitting around for two years!

cosinekitty · cosinekitty · commit 77351490bcbf · 2020-12-16T20:10:09.000-05:00
I made this small change on April 29, 2018, but never checked it in.
It looks like I was delaying regenerating the list of legal
moves a human player could make until right before I check
to see if the given move is legal. It looks legit.
diff --git a/src/human.cpp b/src/human.cpp
@@ -51,9 +51,6 @@ bool HumanChessPlayer::GetMove (
             return false;
         }
 
-        // Regenerate legal moves in case they edited the board.
-        board.GenMoves ( legalMoves );
-
         // The following check allows certain UI tricks to work...
         if ( dest == SPECIAL_MOVE_NULL ||
              (dest & SPECIAL_MOVE_MASK) == SPECIAL_MOVE_EDIT )
@@ -68,6 +65,9 @@ bool HumanChessPlayer::GetMove (
         // This checks for pawn promotion and stuff like that.
         move.Fix ( board, source, dest, promIndex, userInterface );
 
+        // Regenerate legal moves in case they edited the board.
+        board.GenMoves(legalMoves);
+
         // See if the move we just read is legal!
         for ( i=0; i < legalMoves.num; i++ )
         {
