Eliminated warnings reported by gcc 10.2.0.

cosinekitty · cosinekitty · commit 2757637cbd1e · 2020-10-03T13:51:23.000-04:00
diff --git a/src/board.cpp b/src/board.cpp
@@ -1437,7 +1437,7 @@ void GetGameListing (
     int numPlies = board.GetCurrentPlyNumber();
     for ( int i=0; i<numPlies && len<bufSize; i++ )
     {
-        char moveString [64];
+        char moveString[MAX_MOVE_STRLEN + 1];
         char s [64];
         int thisLen = 0;
         Move move = board.GetPastMove(i);
diff --git a/src/chess.h b/src/chess.h
@@ -25,7 +25,11 @@
 
 // The Mac OS X build is basically the same as the Linux build,
 // so I define CHENARD_LINUX as a helper for conditional compilation.
-#define CHENARD_LINUX   (defined(__linux__) || defined(__APPLE__))
+#if defined(__linux__) || defined(__APPLE__)
+#  define CHENARD_LINUX   1
+#else
+#  define CHENARD_LINUX   0
+#endif
 
 #if CHENARD_LINUX
 #define stricmp strcasecmp
diff --git a/src/gamefile.cpp b/src/gamefile.cpp
@@ -578,7 +578,15 @@ bool GetNextPgnMove (
                     switch (tagIndex)
                     {
                     case 0:     // FEN
-                        strncpy(info.fen, token, sizeof(info.fen));
+                        if (strlen(token) < sizeof(info.fen))
+                        {
+                            strcpy(info.fen, token);
+                        }
+                        else
+                        {
+                            state = PGN_FILE_STATE_SYNTAX_ERROR;
+                            goto bail_out;
+                        }
                         break;
 
                     case 1:     // WhiteELO

Original file line number	Diff line number	Diff line change
`@@ -1437,7 +1437,7 @@ void GetGameListing (`
`1437`	`1437`	`int numPlies = board.GetCurrentPlyNumber();`
`1438`	`1438`	`for ( int i=0; i<numPlies && len<bufSize; i++ )`
`1439`	`1439`	`{`
`1440`		`- char moveString [64];`
	`1440`	`+ char moveString[MAX_MOVE_STRLEN + 1];`
`1441`	`1441`	`char s [64];`
`1442`	`1442`	`int thisLen = 0;`
`1443`	`1443`	`Move move = board.GetPastMove(i);`