Skip to content

Conversation

@touchweb-vincent
Copy link
Contributor

Hello,

Quick add

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Copy link
Member

@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed you didn't add these 3 entries to restricted-files.dataandrestricted-upload.data, can you update those data files too?

@touchweb-vincent
Copy link
Contributor Author

Hello,

Done

@touchweb-vincent
Copy link
Contributor Author

@EsadCetiner
Copy link
Member

Interesting, I think there's a race condition with our CI pipeline, that change shouldn't have caused 959100-3 to fail. Tests now pass after re-running them.

@theseion Can you take a look at what might've caused this: https://github.com/coreruleset/coreruleset/actions/runs/18737486580/job/53447100629#step:4:379

Copy link
Member

@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add config/parameters.php to the other config files as well? You should be able to remove config/settings.inc.php as it's covered by our detection for generic config file names.

@theseion
Copy link
Contributor

There's nothing we can do about that, unfortunately. Parsing logs is inherently brittle and we already try very hard to force the web server to flush the log before we try to read it. We're actually pretty lucky that we see these issues only a handful of times per year.

@theseion theseion added the 🚀 enhancement New feature or request label Oct 24, 2025
@theseion theseion changed the title fix(930120): adding conf file for PrestaShop 1.6 / 1.7 / 8+ & Magento 2 feat(930120): adding conf file for PrestaShop 1.6 / 1.7 / 8+ & Magento 2 Oct 24, 2025
@EsadCetiner EsadCetiner added the release:new-detection In this PR we introduce a new detection label Oct 24, 2025
@touchweb-vincent
Copy link
Contributor Author

config/settings.inc.php is not covered : curl -H "x-format-output: txt-matched-rules" -H "x-crs-paranoia-level:4" "https://sandbox.coreruleset.org/?test=/config/settings.inc.php"

Where do you want me to add config/parameters.php ?

@EsadCetiner
Copy link
Member

@touchweb-vincent Sorry, I meant the data files.

These should be added to restricted-upload.data

config/parameters.php
config/settings.inc.php

config/settings.inc.php is not covered

Yes your right, I missed that.

@touchweb-vincent
Copy link
Contributor Author

I didn't add them in restricted-upload.data because there are already present :

config/parameters.php :

/app/config/parameters.php

config/settings.inc.php :
/config/settings.inc.php

@EsadCetiner
Copy link
Member

@touchweb-vincent

That's restricted-files.data, not restricted_upload.data

@touchweb-vincent
Copy link
Contributor Author

Same here :

parameters.php :


settings.inc.php :
settings.inc.php

@EsadCetiner EsadCetiner added this pull request to the merge queue Oct 24, 2025
Merged via the queue into coreruleset:main with commit 8670c69 Oct 24, 2025
10 of 11 checks passed
@touchweb-vincent touchweb-vincent deleted the patch-3 branch October 24, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:new-detection In this PR we introduce a new detection 🚀 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants