-
-
Notifications
You must be signed in to change notification settings - Fork 422
fix(933153): missing inbound_anomaly_score #4260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📊 Quantitative test results for language: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for proposing this PR. Well spotted! The rule 933153 is indeed missing the inbound_anomaly_score increase!
The pipeline is failing. Could you please change the PR title, see the error: https://github.com/coreruleset/coreruleset/actions/runs/17489485816/job/49675785714?pr=4260.
|
Hello @franbuehler done for the title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! LGTM.
Yes, absolutely. @touchweb-vincent could you also update rule 933135 and replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify 933135
Absolutely - but at first glance I'm afraid that's not trivial. We should figure out what rules must contain a |
|
Inbound / outbound could be tricky. But we could simply check that every rule with a paranoia level is setting a corresponding anomaly score variable. |
Hello, done https://github.com/coreruleset/coreruleset/pull/4262/files |
Hello,
Just a quick fix on 933153