Skip to content

Conversation

@Xhoenix
Copy link
Member

@Xhoenix Xhoenix commented Aug 11, 2025

what

  • remove dot star in regex

why

  • optimization

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@Xhoenix Xhoenix requested a review from a team August 11, 2025 11:05
@fzipi
Copy link
Member

fzipi commented Aug 13, 2025

Looks good, but can we do one PR per rule instead?

@Xhoenix
Copy link
Member Author

Xhoenix commented Aug 13, 2025

That won't be much useful in this case, since changing a single regex in regex-assembly/include/unix-shell-evasion-prefix.ra ends up affecting multiple rules.

@theseion theseion added this pull request to the merge queue Aug 14, 2025
Merged via the queue into coreruleset:main with commit 4f1ca4a Aug 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants